All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pekka Enberg <penberg@kernel.org>
To: Prasad Joshi <prasadjoshi124@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>,
	kvm@vger.kernel.org, asias.hejun@gmail.com, gorcunov@gmail.com,
	oswaldo.cadenas@gmail.com
Subject: Re: [PATCH 3/4] Provides the basic Gitish framework
Date: Fri, 08 Apr 2011 08:44:49 +0300	[thread overview]
Message-ID: <1302241489.32207.50.camel@jaguar> (raw)
In-Reply-To: <BANLkTimtrPk4wwk7of32xs0ODDGOKLZT5A@mail.gmail.com>

On Thu, 2011-04-07 at 23:33 +0100, Prasad Joshi wrote:
> On Thu, Apr 7, 2011 at 9:14 PM, Ingo Molnar <mingo@elte.hu> wrote:
> >
> > * Prasad Joshi <prasadjoshi124@gmail.com> wrote:
> >
> >> - kvm-cmd.h: Adds a new structure cmd_struct to create a table of commands
> >>   and callback function.
> >>
> >> - kvm-cmd.c: implements two main functions for command processing.
> >>   kvm_get_command(): searches table for specific command.
> >>   handle_command(): invokes the callback function for a given command.
> >>
> >> - kvm-help.[ch] Implements the kvm help command.
> >
> > Please credit the people/projects from where you took these bits.
> 
> Oh yes!
> struct cmd_struct and list_common_cmds_help() is copied from perf.

Please just add that to the changelog.

			Pekka


  reply	other threads:[~2011-04-08  5:44 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-07 19:47 [PATCH 1/4] Generating list of common kvm tool commands Prasad Joshi
2011-04-07 19:47 ` [PATCH 2/4] Mostly the copied code from perf for argument processing Prasad Joshi
2011-04-07 20:17   ` David Ahern
2011-04-08  5:43     ` Pekka Enberg
2011-04-08  6:04       ` Ingo Molnar
2011-04-07 19:47 ` [PATCH 3/4] Provides the basic Gitish framework Prasad Joshi
2011-04-07 20:14   ` Ingo Molnar
2011-04-07 22:33     ` Prasad Joshi
2011-04-08  5:44       ` Pekka Enberg [this message]
2011-04-08  6:10         ` Ingo Molnar
2011-04-07 19:47 ` [PATCH 4/4] Using the Gitish freamwork to run the virtual machine Prasad Joshi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1302241489.32207.50.camel@jaguar \
    --to=penberg@kernel.org \
    --cc=asias.hejun@gmail.com \
    --cc=gorcunov@gmail.com \
    --cc=kvm@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=oswaldo.cadenas@gmail.com \
    --cc=prasadjoshi124@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.