From: Artem Bityutskiy <dedekind1@gmail.com>
To: Ben Gardiner <bengardiner@nanometrics.ca>
Cc: linux-mtd@lists.infradead.org,
Grant Erickson <marathon96@gmail.com>,
Jarkko Lavinen <jarkko.lavinen@nokia.com>,
Bastian.Ruppert@sewerin.de
Subject: Re: [PATCH v4] Retry Large Buffer Allocations
Date: Sat, 09 Apr 2011 17:39:30 +0300 [thread overview]
Message-ID: <1302359970.2787.12.camel@localhost> (raw)
In-Reply-To: <BANLkTik0LfxcfridxFAGtm2KYpwngvokSQ@mail.gmail.com>
On Fri, 2011-04-08 at 10:45 -0400, Ben Gardiner wrote:
> Hi Grant, Artem
>
> Thanks for this fix!
>
> On Thu, Apr 7, 2011 at 1:40 PM, Grant Erickson <marathon96@gmail.com> wrote:
> > When handling user space read or write requests via mtd_{read,write}
> > or JFFS2 medium scan requests, exponentially back off on the size of
> > the requested kernel transfer buffer until it succeeds or until the
> > requested transfer buffer size falls below the page size.
> >
> > This helps ensure the operation can succeed under low-memory,
> > highly-fragmented situations albeit somewhat more slowly.
> >
> > v2: Incorporated coding style and comment feedback from Artem.
> > v3: Incorporated more feedback from Artem. Retargeted patch against
> > l2-mtd-2.6.
> > v4: Incorporated feedback from Artem about compilation on 64-bit
> > architectures.
> >
> > Signed-off-by: Grant Erickson <marathon96@gmail.com>
>
> I tested this on da850evm by cherry-picking commit
> 64542ac252d378dc7a1122064821a884e85a9954 from
> git://git.infradead.org/users/dedekind/l2-mtd-2.6.git.
Grant sent an updated patch-set and added your Tested-by. However, there
were several conflicts which I had to. If you could test the final
patches again - that'd be great! They are in the same l2-mtd-2.6.git
tree:
8fa3c20 JFFS2: retry large buffer allocations
88ab142 mtd: mtdchar: retry large buffer allocations
99815a5 mtd: create function to perform large allocations
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
prev parent reply other threads:[~2011-04-09 14:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-07 17:40 [PATCH v4] Retry Large Buffer Allocations Grant Erickson
2011-04-08 13:08 ` Artem Bityutskiy
2011-04-08 14:45 ` Ben Gardiner
2011-04-08 15:00 ` Artem Bityutskiy
2011-04-09 14:39 ` Artem Bityutskiy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1302359970.2787.12.camel@localhost \
--to=dedekind1@gmail.com \
--cc=Bastian.Ruppert@sewerin.de \
--cc=bengardiner@nanometrics.ca \
--cc=jarkko.lavinen@nokia.com \
--cc=linux-mtd@lists.infradead.org \
--cc=marathon96@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.