From mboxrd@z Thu Jan 1 00:00:00 1970 From: Liam Girdwood Subject: Re: [alsa-devel] [PATCH] ASoC: SAMSUNG: Fix the inverted clocks handling for pcm driver Date: Mon, 11 Apr 2011 20:53:50 +0100 Message-ID: <1302551630.3449.58.camel@odin> References: <1302314038-11398-1-git-send-email-sbkim73@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-samsung-soc-owner@vger.kernel.org To: Jassi Brar Cc: Sangbeom Kim , alsa-devel@alsa-project.org, kgene.kim@samsung.com, broonie@opensource.wolfsonmicro.com, linux-samsung-soc@vger.kernel.org, ben-linux@fluff.org List-Id: alsa-devel@alsa-project.org On Sat, 2011-04-09 at 10:15 +0530, Jassi Brar wrote: > On Sat, Apr 9, 2011 at 7:23 AM, Sangbeom Kim wrote: > > Fix the inverted clocks handling for pcm cpu driver. > > By using SND_SOC_DAIFMT_NB_NF, Audio noise can be generated on SMDK. > > > > Signed-off-by: Sangbeom Kim > > --- > > sound/soc/samsung/pcm.c | 4 ++-- > > 1 files changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/sound/soc/samsung/pcm.c b/sound/soc/samsung/pcm.c > > index 38aac7d..9c7e8b4 100644 > > --- a/sound/soc/samsung/pcm.c > > +++ b/sound/soc/samsung/pcm.c > > @@ -350,8 +350,8 @@ static int s3c_pcm_set_fmt(struct snd_soc_dai *cpu_dai, > > ctl = readl(regs + S3C_PCM_CTL); > > > > switch (fmt & SND_SOC_DAIFMT_INV_MASK) { > > - case SND_SOC_DAIFMT_NB_NF: > > - /* Nothing to do, NB_NF by default */ > > + case SND_SOC_DAIFMT_IB_NF: > > + /* Nothing to do, IB_NF by default */ > > Assuming you already compared screenshot > of a scope and what's mentioned in the manual for IB_NF ... > > Acked-by: Jassi Brar Acked-by: Liam Girdwood