All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH 3/3] hwmon: (sht15) add checksum validation
Date: Mon, 11 Apr 2011 22:14:26 +0000	[thread overview]
Message-ID: <1302559776-sup-3925@sfl> (raw)
In-Reply-To: <1302198246-22212-4-git-send-email-vivien.didelot@savoirfairelinux.com>

Excerpts from Jonathan Cameron's message of 2011-04-08 14:33:07 -0400:
> Why a u8? It is boolean. Obviously that'll work in a u8 but it almost
> implicitly implies it might contain some data.
> > +    u8                checksumming;

Ok, I've updated flags with the bool type.

> If it's a flag, perhaps u8 implies it might be something other than 0 or 1.
> Admittedly this is true of some of the other elements, but we live and learn.
> >      u8                flag;

As it represents the different states the driver may be in (i.e. what
action it is doing), I've changed it to an enumeration of actions
(nothing, reading temp or humid).

Regards,
Vivien.

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

  parent reply	other threads:[~2011-04-11 22:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-07 17:44 [lm-sensors] [PATCH 3/3] hwmon: (sht15) add checksum validation Vivien Didelot
2011-04-08 18:33 ` Jonathan Cameron
2011-04-11 22:14 ` Vivien Didelot [this message]
2011-04-12  8:03 ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1302559776-sup-3925@sfl \
    --to=vivien.didelot@savoirfairelinux.com \
    --cc=lm-sensors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.