From: Ben Hutchings <bhutchings@solarflare.com>
To: Amit Kumar Salecha <amit.salecha@qlogic.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
ameen.rahman@qlogic.com, anirban.chakraborty@qlogic.com,
Sony Chacko <sony.chacko@qlogic.com>
Subject: Re: [PATCH NEXT 2/2] netxen: support for GbE port settings
Date: Mon, 11 Apr 2011 23:56:38 +0100 [thread overview]
Message-ID: <1302562598.5282.573.camel@localhost> (raw)
In-Reply-To: <1299840277-30591-3-git-send-email-amit.salecha@qlogic.com>
On Fri, 2011-03-11 at 02:44 -0800, Amit Kumar Salecha wrote:
> From: Sony Chacko <sony.chacko@qlogic.com>
>
> o Allow setting speed and auto negotiation parameters for GbE ports.
> o Log an error message to indicate duplex setting is not supported in
> the hardware currently.
[...]
> + ret = nx_fw_cmd_set_gbe_port(adapter, ecmd->speed, ecmd->duplex,
> + ecmd->autoneg);
> + if (ret == NX_RCODE_NOT_SUPPORTED && ecmd->duplex == DUPLEX_HALF) {
> + netdev_info(dev, "Speed and autoneg mode settings supported, "
> + "half duplex mode not supported\n");
> return -EOPNOTSUPP;
[...]
Should be -EINVAL.
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
next prev parent reply other threads:[~2011-04-11 22:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-11 10:44 [PATCH NEXT 0/2]nexten: bug fixes Amit Kumar Salecha
2011-03-11 10:44 ` [PATCH NEXT 1/2] netxen: Notify firmware of Flex-10 interface down Amit Kumar Salecha
2011-03-11 10:44 ` [PATCH NEXT 2/2] netxen: support for GbE port settings Amit Kumar Salecha
2011-04-11 22:56 ` Ben Hutchings [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-03-11 9:50 [PATCH NEXT 0/2]nexten: bug fixes Amit Kumar Salecha
2011-03-11 9:50 ` [PATCH NEXT 2/2] netxen: support for GbE port settings Amit Kumar Salecha
2011-03-14 22:15 ` David Miller
2011-03-14 22:30 ` Ben Hutchings
2011-03-14 22:32 ` David Miller
2011-03-14 22:44 ` Ben Hutchings
2011-03-14 22:54 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1302562598.5282.573.camel@localhost \
--to=bhutchings@solarflare.com \
--cc=ameen.rahman@qlogic.com \
--cc=amit.salecha@qlogic.com \
--cc=anirban.chakraborty@qlogic.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=sony.chacko@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.