From: Artem Bityutskiy <dedekind1@gmail.com>
To: maksim.rayskiy@gmail.com
Cc: linux-mtd@lists.infradead.org, vapier.adi@gmail.com
Subject: Re: [PATCH v2] Fix gcc-4.5.2 "statement with no effect" warnings in UBIFS
Date: Wed, 13 Apr 2011 11:29:01 +0300 [thread overview]
Message-ID: <1302683341.2768.12.camel@localhost> (raw)
In-Reply-To: <1302683190.2768.11.camel@localhost>
On Wed, 2011-04-13 at 11:26 +0300, Artem Bityutskiy wrote:
> On Tue, 2011-04-12 at 15:14 -0700, maksim.rayskiy@gmail.com wrote:
> > From: Maksim Rayskiy <maksim.rayskiy@gmail.com>
> >
> > When compiling UBIFS with CONFIG_UBIFS_FS_DEBUG not set,
> > gcc-4.5.2 generates a slew of "warning: statement with no effect"
> > on references to non-void functions defined as 0.
> > To avoid these warnings, replace #defines with dummy inline functions.
> >
> > Signed-off-by: Maksim Rayskiy <maksim.rayskiy@gmail.com>
>
> This patch does not compile and does not apply to the current tree. I'll
> need to do a lot of massage as well because I dislike the "tabs as
> dynamic spaces" style which you use, and the whole UBIFS code does not
> use this approach, so I would like to maintain consistency.
Sorry, it does compile with older UBIFS, but not with the current one.
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
next prev parent reply other threads:[~2011-04-13 8:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-12 22:14 [PATCH v2] Fix gcc-4.5.2 "statement with no effect" warnings in UBIFS maksim.rayskiy
2011-04-12 22:42 ` Mike Frysinger
2011-04-13 8:26 ` Artem Bityutskiy
2011-04-13 8:29 ` Artem Bityutskiy [this message]
2011-04-13 8:49 ` Maksim Rayskiy
2011-04-13 8:52 ` Artem Bityutskiy
2011-04-13 9:18 ` Artem Bityutskiy
2011-04-13 17:18 ` Maksim Rayskiy
2011-04-14 6:06 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1302683341.2768.12.camel@localhost \
--to=dedekind1@gmail.com \
--cc=linux-mtd@lists.infradead.org \
--cc=maksim.rayskiy@gmail.com \
--cc=vapier.adi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.