All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH v2 2/4] hwmon: (sht15) clean-up the probe
Date: Wed, 13 Apr 2011 13:58:34 +0000	[thread overview]
Message-ID: <1302702429-sup-5170@sfl> (raw)
In-Reply-To: <1302636879-16615-3-git-send-email-vivien.didelot@savoirfairelinux.com>

Hi Jonathan,
Excerpts from Jonathan Cameron's message of 2011-04-13 07:37:37 -0400:
> On 04/12/11 20:34, Vivien Didelot wrote:
> > * Move the creation of sysfs attributes after the end of the
> >   initialization, and remove them in the error path.
> > * Release regulator in the error path.
> > * Add a soft reset command (need to wait 11ms before next command).
> Ideally add something to say why this is needed. (the heater issue that
> Guenter raised).

The soft reset in this patch just ensures to wait 11ms after this
command is sent (previously the probe function didn't deal with that).
The heater issue that Guenter raised (i.e. disabling the heater on
module unload) is fixed in the next patch.

Btw, thanks you all for you comments and reviews.

Regards,
Vivien.

> > 
> > Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
> Acked-by: Jonathan Cameron <jic23@cam.ac.uk>

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

  parent reply	other threads:[~2011-04-13 13:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-12 19:34 [lm-sensors] [PATCH v2 2/4] hwmon: (sht15) clean-up the probe Vivien Didelot
2011-04-13 11:37 ` Jonathan Cameron
2011-04-13 13:58 ` Vivien Didelot [this message]
2011-04-14 21:38 ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1302702429-sup-5170@sfl \
    --to=vivien.didelot@savoirfairelinux.com \
    --cc=lm-sensors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.