From: Artem Bityutskiy <dedekind1@gmail.com>
To: Hans-Christian Egtvedt <hans-christian.egtvedt@atmel.com>
Cc: linux-mtd@lists.infradead.org
Subject: Re: [PATCH 1/2] atmel_nand: add missing include of linux/dmaengine.h
Date: Thu, 14 Apr 2011 16:39:26 +0300 [thread overview]
Message-ID: <1302788366.2796.37.camel@localhost> (raw)
In-Reply-To: <1302702918-6050-1-git-send-email-hans-christian.egtvedt@atmel.com>
On Wed, 2011-04-13 at 15:55 +0200, Hans-Christian Egtvedt wrote:
> Including linux/dmaengine.h fixes the missing definition of the enum
> dma_ctrl_flags type used in atmel_nand_dma_op function.
>
> Signed-off-by: Hans-Christian Egtvedt <hans-christian.egtvedt@atmel.com>
I do not see how it is a problem. C does not support strict types
checking anyway. This all is just 'int'.
IMHO, the enums you invented only make code less readable for C
programmers.
I'd suggest to turn all you enums into anonymous enums and stop using
them as types. That would only make things more readable and easier to
follow.
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
next prev parent reply other threads:[~2011-04-14 13:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-13 13:55 [PATCH 1/2] atmel_nand: add missing include of linux/dmaengine.h Hans-Christian Egtvedt
2011-04-13 13:55 ` [PATCH 2/2] mtd: add switch to support NAND flash on big endian bus Hans-Christian Egtvedt
2011-04-13 14:11 ` Ricard Wanderlof
2011-04-26 11:23 ` Hans-Christian Egtvedt
2011-04-14 12:35 ` Artem Bityutskiy
2011-04-26 11:10 ` Hans-Christian Egtvedt
2011-04-14 13:39 ` Artem Bityutskiy [this message]
2011-04-14 14:01 ` [PATCH 1/2] atmel_nand: add missing include of linux/dmaengine.h Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1302788366.2796.37.camel@localhost \
--to=dedekind1@gmail.com \
--cc=hans-christian.egtvedt@atmel.com \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.