From: Mingming Cao <cmm@us.ibm.com>
To: Yongqiang Yang <xiaoqiangnk@gmail.com>
Cc: "Ted Ts'o" <tytso@mit.edu>,
linux-ext4@vger.kernel.org, achender@linux.vnet.ibm.com
Subject: Re: [PATCH REC 0/3] ext4:Factor common code from convert and split unwritten.
Date: Thu, 14 Apr 2011 11:45:59 -0700 [thread overview]
Message-ID: <1302806759.3408.5.camel@mingming-laptop> (raw)
In-Reply-To: <BANLkTim9okgKc1omQ5dAvTHDrhfA_bpODw@mail.gmail.com>
On Thu, 2011-04-14 at 22:34 +0800, Yongqiang Yang wrote:
> On Thu, Apr 14, 2011 at 10:14 PM, Ted Ts'o <tytso@mit.edu> wrote:
> > On Wed, Apr 13, 2011 at 10:40:48PM -0700, Yongqiang Yang wrote:
> >> These patches factor common code from ext4_ext_convert_to_initialized() and
> >> ext4_split_unwritten_extents(), so that extent-move-on-write in snapshot and
> >> punch-hole can be built on the common code as well.
> >>
> >> ext4:Add a function merging extent right and left.
> >> ext4:Add two functions splitting an extent.
> >> ext4:Reimplement convert and split_unwritten.
> >
> > Hi Yongqiang,
> >
> > I'd like to hear back from Mingming and Allison about whether these
> > patches conflict with their punch patches, since my understanding was
> > they were planning on doing very similar things (and at least would be
> > working in the very similar parts of the code).
> >
> > I agree that the extents code here could definitely use this cleanup,
> > and I'm really glad that you worked on this; thank you! I just want
> > to make sure work you are doing is coordinated with the work that
> > Allison and Mingming are working on.
>
> I knew it and Mingming told me that common code should be factor out
> in previous emails. so I cced patches to Mingming and Allison.
> extent-move-on-write in ext4-snapshots needs a function splitting an
> initialized extent.
>
> These patches indeed need advices, reviews and even tests from
> Mingming and Allison.
Hi Yongqiang,
Thanks for working on this. I took a try before linux filesystem and
storage summit and didn't get completed. I was slightly concerned about
the amount of complexity to adding flags in order to merging the common
code. It's good to hear that you get this far and I will review it.
Allison is working on re-use the direct IO version split code in her
punch hole work, but leave the buffered IO version code unchanged.
Mingming
next prev parent reply other threads:[~2011-04-14 18:46 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-14 5:40 [PATCH REC 0/3] ext4:Factor common code from convert and split unwritten Yongqiang Yang
2011-04-14 5:40 ` [PATCH RFC 1/3] ext4:Add a function merging extent right and left Yongqiang Yang
2011-04-14 19:03 ` Mingming Cao
2011-04-15 1:12 ` Yongqiang Yang
2011-04-15 16:39 ` Mingming Cao
2011-04-14 5:40 ` [PATCH RFC 2/3] ext4:Add two functions splitting an extent Yongqiang Yang
2011-04-20 17:21 ` Allison Henderson
2011-04-20 18:13 ` Andreas Dilger
2011-04-20 20:52 ` Allison Henderson
2011-04-21 1:18 ` Yongqiang Yang
2011-04-14 5:40 ` [PATCH RFC 3/3] ext4:Reimplement convert and split_unwritten Yongqiang Yang
2011-04-21 1:21 ` Yongqiang Yang
2011-04-21 8:28 ` Allison Henderson
2011-04-21 9:10 ` Yongqiang Yang
2011-04-21 21:13 ` Allison Henderson
2011-04-14 14:14 ` [PATCH REC 0/3] ext4:Factor common code from convert and split unwritten Ted Ts'o
2011-04-14 14:34 ` Yongqiang Yang
2011-04-14 18:45 ` Mingming Cao [this message]
2011-04-14 14:36 ` Amir Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1302806759.3408.5.camel@mingming-laptop \
--to=cmm@us.ibm.com \
--cc=achender@linux.vnet.ibm.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=xiaoqiangnk@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.