All of lore.kernel.org
 help / color / mirror / Atom feed
From: Artem Bityutskiy <dedekind1@gmail.com>
To: linux-mtd <linux-mtd@lists.infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	David Woodhouse <dwmw2@infradead.org>,
	jwboyer <jwboyer@gmail.com>
Subject: veto CONFIG_MTD_PARTITIONS?
Date: Fri, 15 Apr 2011 13:09:06 +0300	[thread overview]
Message-ID: <1302862146.3220.23.camel@localhost> (raw)

Hi,

we have a very small mtdpart driver which provides very basic mtd
partitioning services. And this driver may be compiled out. This
probably mattered many years ago, when saving ~7KiB (on arm arch)
mattered a lot.

But this creates mess:

[dedekind@eru l2-mtd-2.6]$ grep -r CONFIG_MTD_PARTITIONS drivers/mtd/* |
wc -l
132

We have really a lot of these "#ifdef CONFIG_MTD_PARTITIONS" statements,
nearly in every driver. And new drivers have this.

I think it is time to declare than saving ~7KiB is not worth the mess
anymore and veto CONFIG_MTD_PARTITIONS - no new "#ifdef
CONFIG_MTD_PARTITIONS" should be accepted.

Someone should just make mtdpart.c to be an integral part of the MTD
core and remove all those #ifdefs.

Hopefully we'll force someone to clean this up.

If no one strongly disagrees, let's veto CONFIG_MTD_PARTITIONS usage.

-- 
Best Regards,
Artem Bityutskiy (Артём Битюцкий)

             reply	other threads:[~2011-04-15 10:12 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-15 10:09 Artem Bityutskiy [this message]
2011-04-18  9:30 ` veto CONFIG_MTD_PARTITIONS? Artem Bityutskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1302862146.3220.23.camel@localhost \
    --to=dedekind1@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=jwboyer@gmail.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.