All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stanislav Brabec <utx@penguin.cz>
To: openembedded-devel@lists.openembedded.org
Subject: [PATCH 2/5] pkgconfig.bbclass: search configs in D instead of S
Date: Sun, 17 Apr 2011 01:24:07 +0200	[thread overview]
Message-ID: <1302996247.3122.32.camel@utx.lan> (raw)

Searching for .pc files in S makes more problems than it
brings benefits. Searching in the installed root seems to be more
logical.

Fixes possible subtle breakages:
- .pc files populated with a different name that upstream intended
- populated .pc files files that were not intended to be populated

Signed-off-by: Stanislav Brabec <utx@penguin.cz>

diff --git a/classes/pkgconfig.bbclass b/classes/pkgconfig.bbclass
index d96b708..00298ca 100644
--- a/classes/pkgconfig.bbclass
+++ b/classes/pkgconfig.bbclass
@@ -14,7 +14,7 @@ SYSROOT_PREPROCESS_FUNCS += "pkgconfig_sysroot_preprocess"
 
 pkgconfig_sysroot_preprocess () {
 	install -d ${SYSROOT_DESTDIR}${PKG_CONFIG_DIR}
-	for pc in `find ${S} -name '*.pc' -type f | grep -v -- '-uninstalled.pc$'`; do
+	for pc in `find ${D} -name '*.pc' -type f`; do
 		pcname=`basename $pc`
 		if [ ! -f ${SYSROOT_DESTDIR}${PKG_CONFIG_DIR}/$pcname ]; then
 			oenote "$pcname was not installed."

-- 

________________________________________________________________________
Stanislav Brabec
http://www.penguin.cz/~utx/zaurus




             reply	other threads:[~2011-04-16 23:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-16 23:24 Stanislav Brabec [this message]
2011-04-19 11:20 ` [PATCH 2/5] pkgconfig.bbclass: search configs in D instead of S Andreas Oberritter
2011-04-20 15:47   ` Stanislav Brabec

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1302996247.3122.32.camel@utx.lan \
    --to=utx@penguin.cz \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.