From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 3/4] task-base: allow distribution to define apm provider
Date: Mon, 18 Apr 2011 09:34:55 +0100 [thread overview]
Message-ID: <1303115695.5518.70.camel@rex> (raw)
In-Reply-To: <f78273c64ab21b1a0691585a2140d5fdf24f3f3a.1303113405.git.Martin.Jansa@gmail.com>
On Mon, 2011-04-18 at 10:00 +0200, Martin Jansa wrote:
> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> ---
> meta/recipes-core/tasks/task-base.bb | 5 ++++-
> 1 files changed, 4 insertions(+), 1 deletions(-)
>
> diff --git a/meta/recipes-core/tasks/task-base.bb b/meta/recipes-core/tasks/task-base.bb
> index 138e617..10f3af4 100644
> --- a/meta/recipes-core/tasks/task-base.bb
> +++ b/meta/recipes-core/tasks/task-base.bb
> @@ -179,8 +179,11 @@ RDEPENDS_task-base-acpi = "\
> acpid \
> libacpi "
>
> +# Distro can override apm provider
> +DISTRO_APM ?= "apm"
> +
> RDEPENDS_task-base-apm = "\
> - apm \
> + ${DISTRO_APM} \
> apmd"
Can you explain a little more about why a distro would do this please?
I'm a little worried this whole file could become a set of DISTRO_*
variables :/.
Cheers,
Richard
next prev parent reply other threads:[~2011-04-18 8:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-18 8:00 [PATCH 0/4] Pull request Martin Jansa
2011-04-18 8:00 ` [PATCH 1/4] gconf-dbus: add SRCREV to recipe Martin Jansa
2011-04-18 8:00 ` [PATCH 2/4] xf86-video-omapfb: " Martin Jansa
2011-04-18 8:03 ` Koen Kooi
2011-04-20 7:06 ` Martin Jansa
2011-04-18 8:00 ` [PATCH 3/4] task-base: allow distribution to define apm provider Martin Jansa
2011-04-18 8:34 ` Richard Purdie [this message]
2011-04-18 8:45 ` Martin Jansa
2011-04-27 20:08 ` Khem Raj
2011-04-27 20:46 ` Koen Kooi
2011-04-27 20:52 ` Khem Raj
2011-04-18 8:00 ` [PATCH 4/4] python-dir.bbclass: define default PYTHON_BASEVERSION Martin Jansa
2011-04-18 8:36 ` Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1303115695.5518.70.camel@rex \
--to=richard.purdie@linuxfoundation.org \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.