From: Ben Hutchings <bhutchings@solarflare.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: monstr@monstr.eu, netdev@vger.kernel.org
Subject: Re: Add NAPI support to ll_temac driver
Date: Tue, 19 Apr 2011 13:25:25 +0100 [thread overview]
Message-ID: <1303215925.3464.54.camel@localhost> (raw)
In-Reply-To: <1303209787.3480.9.camel@edumazet-laptop>
On Tue, 2011-04-19 at 12:43 +0200, Eric Dumazet wrote:
[...]
> One possible way to get better performance is to change driver to
> allocate skbs only right before calling netif_rx(), so that you dont
> have to access cold sk_buff data twice (once when allocating skb and put
> it in ring buffer, a second time when receiving frame)
>
> drivers/net/niu.c is a good example for this (NAPI + netdev_alloc_skb()
> just in time + pull in skbhead only first cache line of packet)
[...]
If the hardware can do RX checksumming (it's not clear) then the driver
should pass the paged buffers into GRO and that will take care of skb
allocation as necessary.
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
next prev parent reply other threads:[~2011-04-19 12:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-19 9:35 Add NAPI support to ll_temac driver Michal Simek
2011-04-19 10:43 ` Eric Dumazet
2011-04-19 12:25 ` Ben Hutchings [this message]
2011-04-19 12:48 ` Michal Simek
2011-04-19 13:13 ` Eric Dumazet
2011-04-19 13:14 ` Ben Hutchings
2011-04-19 13:18 ` Michal Simek
2011-04-20 11:06 ` Michal Simek
2011-04-20 12:47 ` Ben Hutchings
2011-04-19 13:21 ` Eric Dumazet
2011-04-19 12:26 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1303215925.3464.54.camel@localhost \
--to=bhutchings@solarflare.com \
--cc=eric.dumazet@gmail.com \
--cc=monstr@monstr.eu \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.