From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752338Ab1DSWWl (ORCPT ); Tue, 19 Apr 2011 18:22:41 -0400 Received: from mx1.redhat.com ([209.132.183.28]:18099 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751399Ab1DSWWj (ORCPT ); Tue, 19 Apr 2011 18:22:39 -0400 Subject: Re: [PATCH] vfio: Add an ioctl to reset the device From: Alex Williamson To: Chris Wright Cc: pugs@ieee.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, qemu-devel@nongnu.org, aafabbri@cisco.com, dwang2@cisco.com, benve@cisco.com In-Reply-To: <20110419220743.GO12133@x200.localdomain> References: <20110419203234.4254.94914.stgit@s20.home> <20110419220743.GO12133@x200.localdomain> Content-Type: text/plain; charset="UTF-8" Date: Tue, 19 Apr 2011 16:22:31 -0600 Message-ID: <1303251751.3110.129.camel@x201> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2011-04-19 at 15:07 -0700, Chris Wright wrote: > * Alex Williamson (alex.williamson@redhat.com) wrote: > > When using VFIO to assign a device to a guest, we want to make sure > > the device is quiesced on VM reset to stop all DMA within the guest > > mapped memory. Add an ioctl which just calls pci_reset_function() > > and returns whether it succeeds. > > Shouldn't there be a reset when binding/unbinding vfio to/from a pci > device? There's already one when the /dev/vfioX file is opened, we should add another on release, and probably add the same PCI save state store/load that I'm proposing for KVM across those. Thanks, Alex From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:60972) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QCJJg-0003C3-BK for qemu-devel@nongnu.org; Tue, 19 Apr 2011 18:22:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QCJJf-0002jr-HN for qemu-devel@nongnu.org; Tue, 19 Apr 2011 18:22:40 -0400 Received: from mx1.redhat.com ([209.132.183.28]:63739) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QCJJf-0002jn-57 for qemu-devel@nongnu.org; Tue, 19 Apr 2011 18:22:39 -0400 From: Alex Williamson In-Reply-To: <20110419220743.GO12133@x200.localdomain> References: <20110419203234.4254.94914.stgit@s20.home> <20110419220743.GO12133@x200.localdomain> Content-Type: text/plain; charset="UTF-8" Date: Tue, 19 Apr 2011 16:22:31 -0600 Message-ID: <1303251751.3110.129.camel@x201> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] vfio: Add an ioctl to reset the device List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Chris Wright Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, qemu-devel@nongnu.org, aafabbri@cisco.com, dwang2@cisco.com, pugs@ieee.org, benve@cisco.com On Tue, 2011-04-19 at 15:07 -0700, Chris Wright wrote: > * Alex Williamson (alex.williamson@redhat.com) wrote: > > When using VFIO to assign a device to a guest, we want to make sure > > the device is quiesced on VM reset to stop all DMA within the guest > > mapped memory. Add an ioctl which just calls pci_reset_function() > > and returns whether it succeeds. > > Shouldn't there be a reset when binding/unbinding vfio to/from a pci > device? There's already one when the /dev/vfioX file is opened, we should add another on release, and probably add the same PCI save state store/load that I'm proposing for KVM across those. Thanks, Alex