All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alex Elder <aelder@sgi.com>
To: xfs@oss.sgi.com
Subject: [Fwd: Re: [PATCH 4/4] xfs: reduce the number of pagb_lock roundtrips in xfs_alloc_clear_busy]
Date: Thu, 21 Apr 2011 15:09:19 -0500	[thread overview]
Message-ID: <1303416559.2581.522.camel@doink> (raw)

Forgot to reply-all.  Sorry.	-Alex

-------- Forwarded Message --------
From: Alex Elder <aelder@sgi.com>
Reply-to: aelder@sgi.com
To: Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH 4/4] xfs: reduce the number of pagb_lock roundtrips
in xfs_alloc_clear_busy
Date: Thu, 21 Apr 2011 15:08:32 -0500

On Mon, 2011-04-18 at 02:59 -0400, Christoph Hellwig wrote:
> Instead of finding the per-ag and then taking and releasing the pagb_lock
> for every single busy extent completed sort the list of busy extents and
> only switch betweens AGs where nessecary.  This becomes especially important
> with the online discard support which will hit this lock more often.

Looks good.

My only comment was going to be:
    Is it better to sort before when committed, or sort at
    insertion time?
But I worked through it and concluded you are doing exactly
the right thing.

Reviewed-by: Alex Elder <aelder@sgi.com>



_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

                 reply	other threads:[~2011-04-21 20:06 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1303416559.2581.522.camel@doink \
    --to=aelder@sgi.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.