From: Joe Perches <joe@perches.com>
To: michal.simek@petalogix.com
Cc: John Linn <john.linn@xilinx.com>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
alan@lxorguk.ukuu.org.uk, greg@kroah.com,
Grant Likely <grant.likely@secretlab.ca>
Subject: Re: [PATCH V2] tty/serial: add support for Xilinx PS UART
Date: Fri, 22 Apr 2011 02:20:33 -0700 [thread overview]
Message-ID: <1303464033.26896.11.camel@Joe-Laptop> (raw)
In-Reply-To: <4DB14626.8090002@petalogix.com>
On Fri, 2011-04-22 at 11:11 +0200, Michal Simek wrote:
> John Linn wrote:
> > The Xilinx PS Uart is used on the new ARM based SoC. This
> > UART is not compatible with others such that a seperate
> > driver is required.
[]
> > +++ b/drivers/tty/serial/xilinx_uartps.c
[]
> > + rc = uart_add_one_port(&xuartps_uart_driver, port);
> > + if (rc) {
> > + dev_err(&pdev->dev, "uart_add_one_port() failed; \
> > + err=%i\n", rc);
That's a whitespace error.
Please don't be concerned about 80 column lines used for formatting.
You could use something like this as well.
dev_err(&pdev->dev,
"uart_add_one_port() failed; err=%d\n", rc);
next prev parent reply other threads:[~2011-04-22 9:20 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-20 19:03 [PATCH V2] tty/serial: add support for Xilinx PS UART John Linn
2011-04-20 19:03 ` John Linn
2011-04-22 9:11 ` Michal Simek
2011-04-22 9:20 ` Joe Perches [this message]
2011-04-22 13:40 ` John Linn
2011-04-22 13:40 ` John Linn
2011-04-22 13:36 ` John Linn
2011-04-22 13:36 ` John Linn
2011-04-22 16:23 ` Alan Cox
2011-04-22 16:23 ` Alan Cox
2011-04-22 15:12 ` John Linn
2011-04-22 15:12 ` John Linn
2011-04-22 15:22 ` Greg KH
2011-04-22 15:25 ` John Linn
2011-04-22 15:25 ` John Linn
2011-04-22 15:40 ` Grant Likely
2011-04-22 15:40 ` Grant Likely
2011-04-22 15:46 ` Grant Likely
2011-04-22 15:46 ` Grant Likely
2011-04-22 15:55 ` John Linn
2011-04-22 15:55 ` John Linn
2011-04-22 15:47 ` John Linn
2011-04-22 15:47 ` John Linn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1303464033.26896.11.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=grant.likely@secretlab.ca \
--cc=greg@kroah.com \
--cc=john.linn@xilinx.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=michal.simek@petalogix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.