From: Ben Hutchings <bhutchings@solarflare.com>
To: Shan Wei <shanwei@cn.fujitsu.com>
Cc: eilong@broadcom.com, dm@chelsio.com, leedom@chelsio.com,
benve@cisco.com, vkolluri@cisco.com, roprabhu@cisco.com,
dwang2@cisco.com, ron.mercer@qlogic.com, linux-driver@qlogic.com,
David Miller <davem@davemloft.net>,
hadi@cyberus.ca, netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next 3/3] net: fullly using NETIF_F_ALL_TSO
Date: Fri, 22 Apr 2011 15:14:22 +0100 [thread overview]
Message-ID: <1303481662.4129.24.camel@localhost> (raw)
In-Reply-To: <4DB16187.2030904@cn.fujitsu.com>
On Fri, 2011-04-22 at 19:07 +0800, Shan Wei wrote:
> Fullly using NETIF_F_ALL_TSO.
> And some code style tuning. Just compile test.
[...]
This is wrong. What if some other TSO feature is defined and added to
NETIF_F_ALL_TSO later? (This is unlikely, but hopefully you see that it
is conceptually wrong to claim 'all' features.)
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
next prev parent reply other threads:[~2011-04-22 14:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-22 11:07 [PATCH net-next 3/3] net: fullly using NETIF_F_ALL_TSO Shan Wei
2011-04-22 14:14 ` Ben Hutchings [this message]
2011-04-22 15:45 ` Dimitris Michailidis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1303481662.4129.24.camel@localhost \
--to=bhutchings@solarflare.com \
--cc=benve@cisco.com \
--cc=davem@davemloft.net \
--cc=dm@chelsio.com \
--cc=dwang2@cisco.com \
--cc=eilong@broadcom.com \
--cc=hadi@cyberus.ca \
--cc=leedom@chelsio.com \
--cc=linux-driver@qlogic.com \
--cc=netdev@vger.kernel.org \
--cc=ron.mercer@qlogic.com \
--cc=roprabhu@cisco.com \
--cc=shanwei@cn.fujitsu.com \
--cc=vkolluri@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.