From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Williamson Subject: Re: [PATCH] drm/i915/lvds: Only act on lid notify when the device is on Date: Sun, 24 Apr 2011 07:26:46 -0600 Message-ID: <1303651606.3431.4.camel@x201> References: <20110421220803.10321.68968.stgit@localhost6.localdomain6> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by gabe.freedesktop.org (Postfix) with ESMTP id 2E03B9E976 for ; Sun, 24 Apr 2011 06:26:55 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Chris Wilson Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On Sun, 2011-04-24 at 11:05 +0100, Chris Wilson wrote: > On Thu, 21 Apr 2011 16:08:14 -0600, Alex Williamson wrote: > > If we're using vga switcheroo, the device may be turned off > > and poking at it can cause an oops. > > I added just a couple more details to the changelog and added to my -fixes > queue. > > The question for the audience is: what is the difference between using the > PCI power state and the drm->power_switch_state? Seems possible we could use either. I picked the latter because i915_switcheroo_set_state() seems to be keeping it in sync with power state and has the "changing" state, which might help reduce races. Thanks, Alex