From: Ben Hutchings <bhutchings@solarflare.com>
To: Brian Haley <brian.haley@hp.com>
Cc: Jay Vosburgh <fubar@us.ibm.com>,
Andy Gospodarek <andy@greyhouse.net>,
David Miller <davem@davemloft.net>,
Patrick McHardy <kaber@trash.net>,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next-2.6] ipv4,ipv6,bonding: Restore control over number of peer notifications
Date: Wed, 27 Apr 2011 03:14:06 +0100 [thread overview]
Message-ID: <1303870446.3032.399.camel@localhost> (raw)
In-Reply-To: <4DB77AC2.5070207@hp.com>
On Tue, 2011-04-26 at 22:09 -0400, Brian Haley wrote:
> On 04/26/2011 09:25 PM, Ben Hutchings wrote:
> > For backward compatibility, we should retain the module parameters and
> > sysfs attributes to control the number of peer notifications
> > (gratuitous ARPs and unsolicited NAs) sent after bonding failover.
> > Also, it is possible for failover to take place even though the new
> > active slave does not have link up, and in that case the peer
> > notification should be deferred until it does.
> >
> > Change ipv4 and ipv6 so they do not automatically send peer
> > notifications on bonding failover.
> >
> > Change the bonding driver to send separate NETDEV_NOTIFY_PEERS
> > notifications when the link is up, as many times as requested. Since
> > it does not directly control which protocols send notifications, make
> > num_grat_arp and num_unsol_na aliases for a single parameter. Bump
> > the bonding version number and update its documentation.
> >
> > Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
>
> Signed-off-by: Brian Haley <brian.haley@hp.com>
I'm not sure what you mean by this. You didn't write any of it and
you're not a maintainer with your own repository. Did you mean to say
'Reviewed-by' or 'Acked-by'?
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
next prev parent reply other threads:[~2011-04-27 2:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-27 1:25 [PATCH net-next-2.6] ipv4,ipv6,bonding: Restore control over number of peer notifications Ben Hutchings
2011-04-27 1:44 ` Jay Vosburgh
2011-04-27 2:09 ` Brian Haley
2011-04-27 2:14 ` Ben Hutchings [this message]
2011-04-27 14:21 ` Brian Haley
2011-04-29 19:44 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1303870446.3032.399.camel@localhost \
--to=bhutchings@solarflare.com \
--cc=andy@greyhouse.net \
--cc=brian.haley@hp.com \
--cc=davem@davemloft.net \
--cc=fubar@us.ibm.com \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.