All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: anthony@codemonkey.ws
Cc: kwolf@redhat.com, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 2/6] atapi: Move comment to proper place
Date: Tue,  3 May 2011 13:08:22 +0200	[thread overview]
Message-ID: <1304420906-5776-3-git-send-email-kwolf@redhat.com> (raw)
In-Reply-To: <1304420906-5776-1-git-send-email-kwolf@redhat.com>

From: Amit Shah <amit.shah@redhat.com>

Move misplaced comment for media_is_dvd()

Signed-off-by: Amit Shah <amit.shah@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
 hw/ide/atapi.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/hw/ide/atapi.c b/hw/ide/atapi.c
index 690a0ab..86b18d8 100644
--- a/hw/ide/atapi.c
+++ b/hw/ide/atapi.c
@@ -71,12 +71,12 @@ static void lba_to_msf(uint8_t *buf, int lba)
     buf[2] = lba % 75;
 }
 
-/* XXX: DVDs that could fit on a CD will be reported as a CD */
 static inline int media_present(IDEState *s)
 {
     return (s->nb_sectors > 0);
 }
 
+/* XXX: DVDs that could fit on a CD will be reported as a CD */
 static inline int media_is_dvd(IDEState *s)
 {
     return (media_present(s) && s->nb_sectors > CD_MAX_SECTORS);
-- 
1.7.2.3

  parent reply	other threads:[~2011-05-03 11:05 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-03 11:08 [Qemu-devel] [PULL 0/6] Block patches Kevin Wolf
2011-05-03 11:08 ` [Qemu-devel] [PATCH 1/6] qemu-img resize: Fix option parsing Kevin Wolf
2011-05-03 11:08 ` Kevin Wolf [this message]
2011-05-03 11:08 ` [Qemu-devel] [PATCH 3/6] atapi: Explain why we need a 'media not present' state Kevin Wolf
2011-05-03 11:08 ` [Qemu-devel] [PATCH 4/6] ide/atapi: fix set but unused Kevin Wolf
2011-05-03 11:08 ` [Qemu-devel] [PATCH 5/6] qemu-progress.c: printf isn't signal safe Kevin Wolf
2011-05-03 11:08 ` [Qemu-devel] [PATCH 6/6] NBD: Avoid leaking a couple of strings when the NBD device is closed Kevin Wolf
2011-05-03 12:44 ` [Qemu-devel] [PULL 0/6] Block patches Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1304420906-5776-3-git-send-email-kwolf@redhat.com \
    --to=kwolf@redhat.com \
    --cc=anthony@codemonkey.ws \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.