From: Stephen Smalley <sds@tycho.nsa.gov>
To: Daniel J Walsh <dwalsh@redhat.com>
Cc: SELinux <selinux@tycho.nsa.gov>,
Lennart Poettering <lennart@poettering.net>,
Eric Paris <eparis@parisplace.org>
Subject: Re: libselinux mountpoint changing patch.
Date: Tue, 03 May 2011 12:53:05 -0400 [thread overview]
Message-ID: <1304441585.1587.25.camel@moss-pluto> (raw)
In-Reply-To: <4DC02770.1040406@redhat.com>
On Tue, 2011-05-03 at 12:04 -0400, Daniel J Walsh wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On 05/03/2011 11:33 AM, Stephen Smalley wrote:
> > As check_mountpoint() sets selinux_mnt, I'd pick a more descriptive
> > name. Actually, could you perhaps fold the logic into set_selinuxmnt()?
> > That would mean the validation would happen when set_selinuxmnt() gets
> > called by load_policy, which isn't strictly necessary but does no harm.
> >
>
> Done
>
> I have to change set_selinuxmnt to return an int now, though.
> Does this mean we would need an API version bump? Changing from void
> return to int?
Ah, I missed that. We don't want to change the ABI, so I guess you
should leave set_selinuxmnt() alone and make this a new function.
--
Stephen Smalley
National Security Agency
--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.
next prev parent reply other threads:[~2011-05-03 16:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-03 14:50 libselinux mountpoint changing patch Daniel J Walsh
2011-05-03 15:33 ` Stephen Smalley
2011-05-03 16:04 ` Daniel J Walsh
2011-05-03 16:53 ` Stephen Smalley [this message]
2011-05-03 17:13 ` Stephen Smalley
2011-05-03 18:06 ` Daniel J Walsh
2011-08-22 17:26 ` Eric Paris
2011-08-22 17:33 ` Stephen Smalley
2011-08-22 17:52 ` Eric Paris
2011-08-22 18:45 ` Stephen Smalley
2011-08-22 18:52 ` Eric Paris
2011-08-22 19:19 ` Daniel J Walsh
2011-08-22 19:22 ` Daniel J Walsh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1304441585.1587.25.camel@moss-pluto \
--to=sds@tycho.nsa.gov \
--cc=dwalsh@redhat.com \
--cc=eparis@parisplace.org \
--cc=lennart@poettering.net \
--cc=selinux@tycho.nsa.gov \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.