All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alex Elder <aelder@sgi.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: Allison Henderson <achender@linux.vnet.ibm.com>,
	xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfstests: clean up fallocate configuration tests
Date: Tue, 3 May 2011 12:38:43 -0500	[thread overview]
Message-ID: <1304444323.2853.28.camel@doink> (raw)
In-Reply-To: <4DBF492E.3040400@sandeen.net>

On Mon, 2011-05-02 at 19:15 -0500, Eric Sandeen wrote:
> When I added fallocate support to fsx I inadvertently added
> a duplicate fallocate test.
> 
> Consolidate them both into one test (the link test, not the
> compile test) and make all tests use "true" rather than "yes"
> to be more consistent with other tests.

Looks reasonable to me.  I learned a little something
about autoconf while looking at this.  Glad you're an
expert :)

I do see that AC_TRY_COMPILE() is now considered obsolete
so at some point maybe we should update to use the suggested
alternatives (AC_COMPILE_IFELSE() in this example).

Reviewed-by: Alex Elder <aelder@sgi.com>

> Signed-off-by: Eric Sandeen <sandeen@sandeen.net>


_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2011-05-03 17:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-03  0:15 [PATCH] xfstests: clean up fallocate configuration tests Eric Sandeen
2011-05-03 17:38 ` Alex Elder [this message]
2011-05-03 19:03 ` Allison Henderson
2011-05-04 13:48   ` Eric Sandeen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1304444323.2853.28.camel@doink \
    --to=aelder@sgi.com \
    --cc=achender@linux.vnet.ibm.com \
    --cc=sandeen@sandeen.net \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.