From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pekka Enberg Subject: Re: [PATCH] kvm: Fix 32-bit build of the asm/system.h include Date: Thu, 05 May 2011 17:45:01 +0300 Message-ID: <1304606701.10621.1.camel@jaguar> References: <1304454487-2539-2-git-send-email-levinsasha928@gmail.com> <20110503204716.GA27887@elte.hu> <1304484063.13143.9.camel@lappy> <4DC1E57B.3060809@gmail.com> <20110505070211.GA13043@elte.hu> <20110505074716.GC14391@elte.hu> <20110505080729.GD14391@elte.hu> <20110505081253.GA20499@elte.hu> <20110505082215.GA20719@elte.hu> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Cc: Asias He , Sasha Levin , gorcunov@gmail.com, prasadjoshi124@gmail.com, kvm@vger.kernel.org To: Ingo Molnar Return-path: Received: from filtteri2.pp.htv.fi ([213.243.153.185]:38930 "EHLO filtteri2.pp.htv.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751700Ab1EEOpE (ORCPT ); Thu, 5 May 2011 10:45:04 -0400 In-Reply-To: <20110505082215.GA20719@elte.hu> Sender: kvm-owner@vger.kernel.org List-ID: On Thu, 2011-05-05 at 10:22 +0200, Ingo Molnar wrote: > * Ingo Molnar wrote: > > > * Ingo Molnar wrote: > > > > > I'm not entirely happy about how it has added dependent includes to virtio.c > > > but that's a property of this messy header file. Might be worth adding a > > > comment about that. > > > > This block: > > > > > +#include > > > +#include > > > +#include > > > #include > > > > Could be put into a new tools/kvm/include/kvm/barrier.h file, with a comment - > > that way the virtio.c inclusion looks very clean. > > > > Note: i'd not put it into linux/barrier.h, to not clash with any possible > > future linux/barrier.h file, and to also make it clear that this is a kvm > > specific wrapper. > > Like the more complete patch below. Build-tested on 32-bit and 64-bit systems, > boot tested on a 64-bit box. Applied, thanks Ingo! Asias, please let me know if master doesn't build for you still.