Re: [PATCH 3/4] Intel PTI implementaiton of MIPI 1149.7.

[J Freyensee <james_p_freyensee@linux.intel.com>]

On Sun, 2011-04-24 at 03:08 +0200, Jesper Juhl wrote:
> On Sun, 24 Apr 2011, Jesper Juhl wrote:
> 
> > On Fri, 22 Apr 2011, james_p_freyensee@linux.intel.com wrote:
> > 
> ...
> > > +static void pti_tty_cleanup(struct tty_struct *tty)
> > > +{
> > > +	struct pti_tty *pti_tty_data;
> > > +	struct pti_masterchannel *mc;
> > > +
> > > +	pti_tty_data = tty->driver_data;
> > > +
> > > +	if (pti_tty_data != NULL) {
> > > +		mc = pti_tty_data->mc;
> > > +		pti_release_masterchannel(mc);
> > > +		pti_tty_data->mc = NULL;
> > > +	}
> > > +
> > > +	if (pti_tty_data != NULL)
> > > +		kfree(pti_tty_data);
> > > +
> > > +	tty->driver_data = NULL;
> > > +}
> > 
> > How about this instead?
> > 
> > static void pti_tty_cleanup(struct tty_struct *tty)
> > {
> >      if (!tty->driver_data)
> >              return;
> >      pti_release_masterchannel(tty->driver_data->mc);

I like this suggestion.  I'll incorporate this.  

> >      kfree(tty->driver_data);

I'm no means an expert in the kernel, but I assume kfree() is like C
free(), that it's a nop if it receives a NULL value?

> > }
> > 
> I meant to say :
> 
> static void pti_tty_cleanup(struct tty_struct *tty)
> {
>      if (!tty->driver_data)
>              return;
>      pti_release_masterchannel(tty->driver_data->mc);
>      kfree(tty->driver_data);
>      tty->driver_data = NULL
> }   
> 
>