Re: [PATCH 4/6] ASoC: OMAP: Add CPU DAI driver for HDMI

[Ricardo Neri <ricardo.neri@ti.com>]

Hi Mark,

Am Donnerstag, den 05.05.2011, 03:22 -0500 schrieb Mark Brown:
> On Thu, May 05, 2011 at 02:21:51AM -0500, Ricardo Neri wrote:
> 
> > +static int omap_hdmi_dai_startup(struct snd_pcm_substream *substream,
> > +				  struct snd_soc_dai *dai)
> > +{
> 
> > +	if (ovl->manager->device->state != OMAP_DSS_DISPLAY_ACTIVE) {
> > +		pr_err("HDMI display is not active!\n");
> > +		return -EIO;
> > +	}
> 
> dev_er().  Also, why are you checking this, and are you checking it too
> early?

I will replace with dev_err(). I need to check if HDMI display is active
because the HDMI DSS driver is in charge of powering on/off the HDMI IP.
Audio can play only if the HDMI IP is on. I don't have a .trigger
function in my DAI so I thought it was OK to perform the check
at .startup. Do you think I should create a .trigger function and
perform the check from there?
> 
> > +MODULE_AUTHOR("Jorge Candelaria <jorge.candelaria@gmail.com>");
> > +MODULE_AUTHOR("Ricardo Neri <ricardo.neri@ti.com>");
> > +MODULE_DESCRIPTION("OMAP HDMI SoC Interface");
> > +MODULE_LICENSE("GPL");
> 
> MODULE_ALIAS().
I will add.