From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from he.sipsolutions.net ([78.46.109.217]:60725 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752666Ab1EFWiJ (ORCPT ); Fri, 6 May 2011 18:38:09 -0400 Subject: Re: [PATCH] mac80211: Only process mesh PREPs with equal seq number if metric is better. From: Johannes Berg To: Javier Cardona Cc: "John W. Linville" , Fabrice Deyber , Thomas Pedersen , devel@lists.open80211s.org, linux-wireless@vger.kernel.org, jlopex@gmail.com In-Reply-To: (sfid-20110507_002848_039627_E0EBE5C8) References: <1304719911-22636-1-git-send-email-javier@cozybit.com> <1304720248.3595.13.camel@jlt3.sipsolutions.net> (sfid-20110507_002848_039627_E0EBE5C8) Content-Type: text/plain; charset="UTF-8" Date: Sat, 07 May 2011 00:38:05 +0200 Message-ID: <1304721485.3595.15.camel@jlt3.sipsolutions.net> (sfid-20110507_003814_598232_C5F9B8B9) Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Fri, 2011-05-06 at 15:28 -0700, Javier Cardona wrote: > >> This fixes routing loops in PREP propagation and is in accordance with Draft > >> 11, Section: 11C.9.8.4. > > > >> +++ b/net/mac80211/mesh_hwmp.c > >> @@ -391,7 +391,6 @@ static u32 hwmp_route_info_get(struct ieee80211_sub_if_data *sdata, > >> (mpath->flags & MESH_PATH_SN_VALID)) { > >> if (SN_GT(mpath->sn, orig_sn) || > >> (mpath->sn == orig_sn && > >> - action == MPATH_PREQ && > > > > I don't understand how removing the action comparison maps to the patch > > description -- can you explain a bit more? > > If the if condition is true, this PREQ or PREP will be ignored. The > first part of the condition eliminates old sequence numbers, where the > metric is not checked. The second part of the if condidion (|| > (mpath->sn == ...) used to eliminate all the PREQs with equal seq > number and worse metric. The patch modifies it to also eliminate > PREPs. Ah. Thanks for the explanation, guess I shouldn't be trying to read this after midnight :-) johannes