Re: [meta-oe][PATCH v3 06/11] p910nd: add version 0.95

[Phil Blundell <philb@gnu.org>]

On Sun, 2011-05-08 at 16:41 +0000, Otavio Salvador wrote:
> +++ b/meta-oe/recipes-support/p910nd/files/p910nd.init
> @@ -0,0 +1,31 @@
> +#! /bin/sh
> +
> +test -f /usr/sbin/p910nd || exit 0
> +
> +test -d /var/spool/p910nd || mkdir -p /var/spool/p910nd

This script seems to include a lot of hardwired assumptions about distro
file layout.  Could you make it respect ${sbindir} et al.?

> +    echo -n "Starting p910nd printer daemon: p910nd"
> +    /usr/sbin/p910nd -b -f /dev/usb/lp0 0

... and likewise here, this device node seems a bit over-specific.

> +    echo "."
> +    ;;
> +  stop)
> +    echo -n "Stopping p910nd printer daemon: p910nd"
> +    start-stop-daemon --stop --quiet --exec /usr/sbin/p9100d

This doesn't look like it's going to work: it tries to stop "p9100d" but
that doesn't seem to be the correct name of the executable.

> +do_compile () {
> +	${CC} ${LDFLAGS} -o p910nd p910nd.c
> +}

Shouldn't this also mention $(CFLAGS)?

p.