From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 1/3] cmake.bbclass: fix qmake and rpath issues
Date: Wed, 11 May 2011 16:14:37 +0100 [thread overview]
Message-ID: <1305126877.30391.371.camel@rex> (raw)
In-Reply-To: <BANLkTimnZyL-Jr0Dyd-CgPKk9k_n_HBT-g@mail.gmail.com>
On Tue, 2011-05-10 at 17:04 -0300, Otavio Salvador wrote:
> On Tue, May 10, 2011 at 16:59, Saul Wold <sgw@linux.intel.com> wrote:
> > In Richard's email he proposed one or the other be set, why do you need to
> > set both here? If both need to be set then you don't need the override.
>
> Because they're different no? Otherwise native.bbclass has those for others too:
>
> ...
> PACKAGES = ""
> PACKAGES_virtclass-native = ""
> PACKAGES_DYNAMIC = ""
> PACKAGES_DYNAMIC_virtclass-native = ""
> ...
>
> Seems logical, no?
What I'm proposing is that native.bbclass should probably set the
override even when its not being used as a BBCLASSEXTEND.
All things considered lets make that a separate change and I'll take
this as is though because as you point out, there are other variables
with this issue too.
Cheers,
Richard
next prev parent reply other threads:[~2011-05-11 15:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-10 14:51 [PATCH 1/3] cmake.bbclass: fix qmake and rpath issues Otavio Salvador
2011-05-10 14:51 ` [PATCH 2/3] qmake_base.bbclass: add generate_qt_config_file task Otavio Salvador
2011-05-11 15:16 ` Richard Purdie
2011-05-10 14:51 ` [PATCH 3/3] cmake: add support for oe qt4 tools names Otavio Salvador
2011-05-11 15:17 ` Richard Purdie
2011-05-12 1:11 ` Otavio Salvador
2011-05-10 19:59 ` [PATCH 1/3] cmake.bbclass: fix qmake and rpath issues Saul Wold
2011-05-10 20:04 ` Otavio Salvador
2011-05-11 15:14 ` Richard Purdie [this message]
2011-05-11 15:15 ` Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1305126877.30391.371.camel@rex \
--to=richard.purdie@linuxfoundation.org \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.