Re: [PATCH 1/4] crownbay: remove custom BASE_PACKAGE_ARCH and PACKAGE_EXTRA_ARCHS

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Sat, 2011-05-14 at 21:18 -0700, Saul Wold wrote:
> On 05/14/2011 08:36 PM, Tom Zanussi wrote:
> > From: Tom Zanussi<tom.zanussi@intel.com>
> >
> > PACKAGE_EXTRA_ARCHS in the conf file gets overwritten by the tune-atom
> > include following it, preventing the atom BASE_PACKAGE_ARCH from being
> > included in the final PACKAGE_ARCHS and causing do_rootfs to fail.
> > Remove the atom BASE_PACKAGE_ARCH and PACKAGE_EXTRA_ARCHS in the conf
> > file and allow the values in tune-atom to be used as intended.
> >
> I think we may still want to change the tune-atom PACKAGE_EXTRA_ARCHS to ?=.

No, we really don't want to do that ;-). 

The whole point behind the tune-* include files is they are the one
correct place where these architecture specific flags get setup
correctly. Experience shows people trying to do it in each machine file
get it wrong more often than right, this machine file being a perfect
example.

If some different flags are needed, we create a new tune-xxx file which
can either inherit another and customise or set the correct values
itself.

Cheers,

Richard

> > Fixes [BUGID #986].
> >
> Should be [YOCTO #986]
> 
> > Signed-off-by: Tom Zanussi<tom.zanussi@intel.com>
> > ---
> >   meta-crownbay/conf/machine/crownbay.conf |    3 ---
> >   1 files changed, 0 insertions(+), 3 deletions(-)
> >
> > diff --git a/meta-crownbay/conf/machine/crownbay.conf b/meta-crownbay/conf/machine/crownbay.conf
> > index b8f107b..bc09ada 100644
> > --- a/meta-crownbay/conf/machine/crownbay.conf
> > +++ b/meta-crownbay/conf/machine/crownbay.conf
> > @@ -5,12 +5,9 @@
> >   # i.e. E660 + EG20T
> >
> >   TARGET_ARCH = "i586"
> > -PACKAGE_EXTRA_ARCHS = "x86 atom"
> >
> >   include conf/machine/include/tune-atom.inc
> >
> > -BASE_PACKAGE_ARCH="atom"
> > -
> >   MACHINE_FEATURES = "kernel26 screen keyboard pci usbhost ext2 ext3 x86 \
> >                       acpi serial usbgadget"
> >
> 
> _______________________________________________
> poky mailing list
> poky@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/poky