All of lore.kernel.org
 help / color / mirror / Atom feed
From: Phil Blundell <philb@gnu.org>
To: openembedded-devel@lists.openembedded.org
Subject: Re: [PATCH 1/2] kernel.bbclass: pass KERNEL_VERSION through legitimize_package_name
Date: Mon, 16 May 2011 12:45:47 +0100	[thread overview]
Message-ID: <1305546347.2429.3.camel@phil-desktop> (raw)
In-Reply-To: <4DD10D20.6080005@opendreambox.org>

I can't help thinking that, in this day and age, those PKG assignments
probably belong in some distro configuration rather than the recipe
itself, and it might be worth thinking about booting them out at some
point.  But, as long as they are there, your change is obviously
sensible.

Acked-by: Phil Blundell <philb@gnu.org>

p.

On Mon, 2011-05-16 at 13:40 +0200, Andreas Oberritter wrote:
> Ping
> 
> On 04/15/2011 02:03 AM, Andreas Oberritter wrote:
> > - KERNEL_VERSION may contain characters unsuitable for package
> >   names, e.g. underscores. Use legitimize_package_name to replace
> >   those characters.
> > 
> > Signed-off-by: Andreas Oberritter <obi@opendreambox.org>
> > ---
> >  classes/kernel.bbclass |    4 ++--
> >  1 files changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/classes/kernel.bbclass b/classes/kernel.bbclass
> > index 0187fb3..bded15d 100644
> > --- a/classes/kernel.bbclass
> > +++ b/classes/kernel.bbclass
> > @@ -245,8 +245,8 @@ RDEPENDS_kernel = "kernel-base"
> >  # Allow machines to override this dependency if kernel image files are 
> >  # not wanted in images as standard
> >  RDEPENDS_kernel-base ?= "kernel-image"
> > -PKG_kernel-image = "kernel-image-${KERNEL_VERSION}"
> > -PKG_kernel-base = "kernel-${KERNEL_VERSION}"
> > +PKG_kernel-image = "kernel-image-${@legitimize_package_name('${KERNEL_VERSION}')}"
> > +PKG_kernel-base = "kernel-${@legitimize_package_name('${KERNEL_VERSION}')}"
> >  ALLOW_EMPTY_kernel = "1"
> >  ALLOW_EMPTY_kernel-base = "1"
> >  ALLOW_EMPTY_kernel-image = "1"
> 
> 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel





      reply	other threads:[~2011-05-16 11:48 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-15  0:03 [PATCH 1/2] kernel.bbclass: pass KERNEL_VERSION through legitimize_package_name Andreas Oberritter
2011-04-15  0:03 ` [PATCH 2/2] kernel.bbclass: pass AR, NM and OBJCOPY to make Andreas Oberritter
2011-05-16 11:40   ` Andreas Oberritter
2011-05-16 11:44     ` Phil Blundell
2011-05-16 12:14       ` Andreas Oberritter
2011-05-16 11:40 ` [PATCH 1/2] kernel.bbclass: pass KERNEL_VERSION through legitimize_package_name Andreas Oberritter
2011-05-16 11:45   ` Phil Blundell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1305546347.2429.3.camel@phil-desktop \
    --to=philb@gnu.org \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.