From: "Guy, Wey-Yi" <wey-yi.w.guy@intel.com>
To: Daniel Halperin <dhalperi@cs.washington.edu>
Cc: linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] iwlwifi: remove unused parameter from iwl_hcmd_queue_reclaim
Date: Tue, 17 May 2011 07:24:03 -0700 [thread overview]
Message-ID: <1305642243.14995.280.camel@wwguy-huron> (raw)
In-Reply-To: <9506853D-331A-4900-BAA3-61C3CB280AAD@cs.washington.edu>
On Mon, 2011-05-16 at 21:46 -0700, Daniel Halperin wrote:
> cmd_index is never used.
>
> Signed-off-by: Daniel Halperin <dhalperi@cs.washington.edu>
> ---
> drivers/net/wireless/iwlwifi/iwl-tx.c | 5 ++---
> 1 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/wireless/iwlwifi/iwl-tx.c b/drivers/net/wireless/iwlwifi/iwl-tx.c
> index 54a935f..686e176 100644
> --- a/drivers/net/wireless/iwlwifi/iwl-tx.c
> +++ b/drivers/net/wireless/iwlwifi/iwl-tx.c
> @@ -746,8 +746,7 @@ int iwl_enqueue_hcmd(struct iwl_priv *priv, struct iwl_host_cmd *cmd)
> * need to be reclaimed. As result, some free space forms. If there is
> * enough free space (> low mark), wake the stack that feeds us.
> */
> -static void iwl_hcmd_queue_reclaim(struct iwl_priv *priv, int txq_id,
> - int idx, int cmd_idx)
> +static void iwl_hcmd_queue_reclaim(struct iwl_priv *priv, int txq_id, int idx)
> {
> struct iwl_tx_queue *txq = &priv->txq[txq_id];
> struct iwl_queue *q = &txq->q;
> @@ -819,7 +818,7 @@ void iwl_tx_cmd_complete(struct iwl_priv *priv, struct iwl_rx_mem_buffer *rxb)
>
> spin_lock_irqsave(&priv->hcmd_lock, flags);
>
> - iwl_hcmd_queue_reclaim(priv, txq_id, index, cmd_index);
> + iwl_hcmd_queue_reclaim(priv, txq_id, index);
>
> if (!(meta->flags & CMD_ASYNC)) {
> clear_bit(STATUS_HCMD_ACTIVE, &priv->status);
Thanks
Wey
prev parent reply other threads:[~2011-05-17 14:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-17 4:46 [PATCH] iwlwifi: remove unused parameter from iwl_hcmd_queue_reclaim Daniel Halperin
2011-05-17 14:24 ` Guy, Wey-Yi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1305642243.14995.280.camel@wwguy-huron \
--to=wey-yi.w.guy@intel.com \
--cc=dhalperi@cs.washington.edu \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.