From: Mark Salter <msalter@redhat.com>
To: arnd@arndb.de
Cc: linux-arch@vger.kernel.org
Subject: [PATCH] fix generic get_user and put_user
Date: Tue, 17 May 2011 14:35:49 -0400 [thread overview]
Message-ID: <1305657349-2783-1-git-send-email-msalter@redhat.com> (raw)
The generic uaccess.h implements get_user() and put_user() as macros. The
current version of these do not properly handle pointers passed in with
post-increment and the like. In the case of put_user(0, ptr++), ptr gets
incremented twice. Once for the call to access_ok() and once in __put_user().
This patch creates a local copy of the pointer so that it is safe to use
post/pre increment/decrement on the pointer arg.
Signed-off-by: Mark Salter <msalter@redhat.com>
---
include/asm-generic/uaccess.h | 10 ++++++----
1 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/include/asm-generic/uaccess.h b/include/asm-generic/uaccess.h
index 1d0fdf8..5079335 100644
--- a/include/asm-generic/uaccess.h
+++ b/include/asm-generic/uaccess.h
@@ -162,9 +162,10 @@ static inline __must_check long __copy_to_user(void __user *to,
#define put_user(x, ptr) \
({ \
+ __typeof__(*(ptr)) *__pu_ptr = (ptr); \
might_sleep(); \
- access_ok(VERIFY_WRITE, ptr, sizeof(*ptr)) ? \
- __put_user(x, ptr) : \
+ access_ok(VERIFY_WRITE, __pu_ptr, sizeof(*ptr)) ? \
+ __put_user(x, __pu_ptr) : \
-EFAULT; \
})
@@ -218,9 +219,10 @@ extern int __put_user_bad(void) __attribute__((noreturn));
#define get_user(x, ptr) \
({ \
+ __typeof__(*(ptr)) *__gu_ptr = (ptr); \
might_sleep(); \
- access_ok(VERIFY_READ, ptr, sizeof(*ptr)) ? \
- __get_user(x, ptr) : \
+ access_ok(VERIFY_READ, __gu_ptr, sizeof(*ptr)) ? \
+ __get_user(x, __gu_ptr) : \
-EFAULT; \
})
--
1.6.2.5
next reply other threads:[~2011-05-17 18:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-17 18:35 Mark Salter [this message]
2011-05-17 20:26 ` [PATCH] fix generic get_user and put_user Arnd Bergmann
2011-05-17 21:25 ` Mark Salter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1305657349-2783-1-git-send-email-msalter@redhat.com \
--to=msalter@redhat.com \
--cc=arnd@arndb.de \
--cc=linux-arch@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.