From: Chris Mason <chris.mason@oracle.com>
To: David Sterba <dsterba@suse.cz>
Cc: linux-btrfs <linux-btrfs@vger.kernel.org>,
lidongyang <lidongyang@novell.com>, stable <stable@kernel.org>
Subject: Re: [PATCH] btrfs: fix crash when no drive supports DISCARD
Date: Tue, 17 May 2011 14:49:00 -0400 [thread overview]
Message-ID: <1305658043-sup-7384@shiny> (raw)
In-Reply-To: <1305648031-26379-1-git-send-email-dsterba@suse.cz>
Excerpts from David Sterba's message of 2011-05-17 12:00:31 -0400:
> xfstests/013 crashes when the test partition is mounted with -o discard:
>
> walk_up_log_tree
> btrfs_free_reserved_extent
> btrfs_discard_extent
> return -EOPNOTSUPP
> BUG_ON ret
>
> btrfs_discard_extent() should be fine when drive does not support the
> DISCARD operation and filter the EOPNOTSUPP retcode, but currently it
> does this only when some bytes were succesfully discarded.
Fair enough, we aren't really doing anything with EOPNOTSUPP now, so we
can just drop it in btrfs_discard_extent.
-chris
next prev parent reply other threads:[~2011-05-17 18:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-17 15:27 Drive without DISCARD support crashes btrfs David Sterba
2011-05-17 16:00 ` [PATCH] btrfs: fix crash when no drive supports DISCARD David Sterba
2011-05-17 18:49 ` Chris Mason [this message]
2011-05-18 3:29 ` Li Dongyang
2011-05-20 11:52 ` David Sterba
2011-05-20 14:15 ` Josef Bacik
2011-05-21 8:26 ` Li Dongyang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1305658043-sup-7384@shiny \
--to=chris.mason@oracle.com \
--cc=dsterba@suse.cz \
--cc=lidongyang@novell.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.