All of lore.kernel.org
 help / color / mirror / Atom feed
From: Liam Girdwood <lrg@kernel.org>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Balaji T K <balajitk@ti.com>,
	linux-omap@vger.kernel.org, lrg@ti.com, gg@slimlogic.co.uk
Subject: Re: [PATCH 1/2] regulator: twl6030: do not write to _GRP for regulator enable
Date: Sun, 22 May 2011 10:26:28 +0100	[thread overview]
Message-ID: <1306056388.3263.4.camel@odin> (raw)
In-Reply-To: <20110522065013.GA18955@opensource.wolfsonmicro.com>

On Sun, 2011-05-22 at 14:50 +0800, Mark Brown wrote:
> On Fri, May 20, 2011 at 07:03:51PM +0530, Balaji T K wrote:
> > TWL6030: regulator is enabled via VREG_STATE
> > TWL4030: regulator is enabled via VREG_GRP
> > Since there is nothing common, split twlreg_enable similar to other regulator_ops
> > 
> > Signed-off-by: Balaji T K <balajitk@ti.com>
> 
> Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> 
> but
> 
> >  
> >  	udelay(info->delay);
> 
> all these need to be replaced by implementing get_enable_time().

Both Applied.

Can you fix this incrementally.

Thanks

Liam


  reply	other threads:[~2011-05-22  9:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-20 13:33 [PATCH 0/2] regulator: twl6030: do not write to _GRP for enable/disable Balaji T K
2011-05-20 13:33 ` [PATCH 1/2] regulator: twl6030: do not write to _GRP for regulator enable Balaji T K
2011-05-22  6:50   ` Mark Brown
2011-05-22  9:26     ` Liam Girdwood [this message]
2011-05-20 13:33 ` [PATCH 2/2] regulator: twl6030: do not write to _GRP for regulator disable Balaji T K
2011-05-22  6:59   ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1306056388.3263.4.camel@odin \
    --to=lrg@kernel.org \
    --cc=balajitk@ti.com \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=gg@slimlogic.co.uk \
    --cc=linux-omap@vger.kernel.org \
    --cc=lrg@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.