All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Hutchings <bhutchings@solarflare.com>
To: Yaniv Rosner <yanivr@broadcom.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, eilong@broadcom.com
Subject: Re: [PATCH net-next 04/11] bnx2x: Add TX fault check for fiber PHYs
Date: Sun, 22 May 2011 22:20:18 -0700	[thread overview]
Message-ID: <1306128018.3456.35.camel@localhost> (raw)
In-Reply-To: <1306063927.20872.86.camel@lb-tlvb-dmitry>

On Sun, 2011-05-22 at 14:32 +0300, Yaniv Rosner wrote:
> In case TX fault is detected on Fiber PHYs, declare the link as down
> until TX fault is gone.
[...]
> --- a/drivers/net/bnx2x/bnx2x_reg.h
> +++ b/drivers/net/bnx2x/bnx2x_reg.h
> @@ -6037,6 +6037,7 @@ Theotherbitsarereservedandshouldbezero*/
>  #define MDIO_PMA_REG_BCM_CTRL		0x0096
>  #define MDIO_PMA_REG_FEC_CTRL		0x00ab
>  #define MDIO_PMA_REG_RX_ALARM_CTRL	0x9000
> +#define MDIO_PMA_REG_TX_ALARM_CTRL	0x9001
>  #define MDIO_PMA_REG_LASI_CTRL		0x9002
>  #define MDIO_PMA_REG_RX_ALARM		0x9003
>  #define MDIO_PMA_REG_TX_ALARM		0x9004

By the way, the LASI registers are already named in <linux/mdio.h>:

#define MDIO_PMA_LASI_RXCTRL	0x9000	/* RX_ALARM control */
#define MDIO_PMA_LASI_TXCTRL	0x9001	/* TX_ALARM control */
#define MDIO_PMA_LASI_CTRL	0x9002	/* LASI control */
#define MDIO_PMA_LASI_RXSTAT	0x9003	/* RX_ALARM status */
#define MDIO_PMA_LASI_TXSTAT	0x9004	/* TX_ALARM status */
#define MDIO_PMA_LASI_STAT	0x9005	/* LASI status */

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.


  reply	other threads:[~2011-05-23  5:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-22 11:32 [PATCH net-next 04/11] bnx2x: Add TX fault check for fiber PHYs Yaniv Rosner
2011-05-23  5:20 ` Ben Hutchings [this message]
2011-05-23  6:46   ` Yaniv Rosner
  -- strict thread matches above, loose matches on Subject: below --
2011-06-01  7:27 Yaniv Rosner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1306128018.3456.35.camel@localhost \
    --to=bhutchings@solarflare.com \
    --cc=davem@davemloft.net \
    --cc=eilong@broadcom.com \
    --cc=netdev@vger.kernel.org \
    --cc=yanivr@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.