From: Peter Zijlstra <peterz@infradead.org>
To: Stephane Eranian <eranian@google.com>
Cc: linux-kernel@vger.kernel.org, mingo@elte.hu, andi@firstfloor.org,
ming.m.lin@intel.com
Subject: Re: [PATCH 2/3] perf_events: fix validation of events using an extra reg (v2)
Date: Mon, 23 May 2011 09:47:58 +0200 [thread overview]
Message-ID: <1306136878.18455.4.camel@twins> (raw)
In-Reply-To: <BANLkTimZhpfgKoEki16r5zabNCrvK-GsUw@mail.gmail.com>
On Fri, 2011-05-20 at 18:45 +0200, Stephane Eranian wrote:
> On Fri, May 20, 2011 at 5:05 PM, Peter Zijlstra <peterz@infradead.org> wrote:
> > On Fri, 2011-05-20 at 16:37 +0200, Stephane Eranian wrote:
> >> The is_fake field is necessary to avoid a lockdep issue having
> >> to do with interrupt masking and era->lock.
> >
> > Why not simply disable IRQs in both validate_* functions?
> >
> Could do that too if you think that's cleaner.
Its saner than making that code path conditional, but an alternative
solution is to give the fake thing a different lock class.
next prev parent reply other threads:[~2011-05-23 7:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-20 14:37 [PATCH 2/3] perf_events: fix validation of events using an extra reg (v2) Stephane Eranian
2011-05-20 15:05 ` Peter Zijlstra
2011-05-20 16:45 ` Stephane Eranian
2011-05-23 7:47 ` Peter Zijlstra [this message]
2011-05-23 9:15 ` Stephane Eranian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1306136878.18455.4.camel@twins \
--to=peterz@infradead.org \
--cc=andi@firstfloor.org \
--cc=eranian@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.m.lin@intel.com \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.