All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joe Thornber <thornber@redhat.com>
To: device-mapper development <dm-devel@redhat.com>
Cc: "Alasdair G. Kergon" <agk@redhat.com>
Subject: Re: [PATCH] Remove the spinlock protecting the pages allocation
Date: Mon, 23 May 2011 09:59:07 +0100	[thread overview]
Message-ID: <1306141147.3404.4.camel@ubuntu> (raw)
In-Reply-To: <Pine.LNX.4.64.1105191257430.17915@hs20-bc2-1.build.redhat.com>

On Thu, 2011-05-19 at 12:58 -0400, Mikulas Patocka wrote:
> The spinlock is only taken on initialization or from single-threaded
> workqueue.
> Therefore, the spinlock is useless. 

The spinlock has memory barrier semantics as well.  How are you
guaranteeing the changes from the initialisation thread are visible in
the workqueue thread?

- Joe

  reply	other threads:[~2011-05-23  8:59 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-19 16:58 [PATCH] Remove the spinlock protecting the pages allocation Mikulas Patocka
2011-05-23  8:59 ` Joe Thornber [this message]
2011-05-26 12:50   ` Mikulas Patocka
2011-05-26 12:52     ` Joe Thornber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1306141147.3404.4.camel@ubuntu \
    --to=thornber@redhat.com \
    --cc=agk@redhat.com \
    --cc=dm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.