From: Phil Blundell <pb@pbcl.net>
To: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 2/9] update-alternatives-dpkg: Update to dpkg base 1.15.8.7
Date: Mon, 23 May 2011 10:29:03 +0100 [thread overview]
Message-ID: <1306142943.2525.35.camel@phil-desktop> (raw)
In-Reply-To: <f69c937a66b3dc7055eb3454b0fbec60fd894bab.1306089781.git.sgw@linux.intel.com>
On Sun, 2011-05-22 at 11:48 -0700, Saul Wold wrote:
> --- a/meta/recipes-devtools/update-alternatives/update-alternatives-dpkg.inc
> +++ b/meta/recipes-devtools/update-alternatives/update-alternatives-dpkg.inc
> @@ -5,10 +5,12 @@ programs fulfilling the same or similar functions and how they can be installed
> time."
> LICENSE = "GPL"
> SECTION = "base"
> -SRC_URI = "${DEBIAN_MIRROR}/main/d/dpkg/dpkg_${PV}.tar.gz"
> +SRC_URI = "${DEBIAN_MIRROR}/main/d/dpkg/dpkg_${PV}.tar.bz2"
> S = "${WORKDIR}/dpkg-${PV}"
> PACKAGE_ARCH = "all"
> -PR = "r2"
> +PR = "r0"
Why is this in the .inc file at all? It seems a bit bogus to have a PR
value defined here that needs to be rewound whenever PV is changed
somewhere else.
> +PROVIDES += "virtual/update-alternatives"
> +RPROVIDES_${PN} += "update-alternatives"
> +EXTRA_RDEPENDS = "perl dpkg"
> +EXTRA_RDEPENDS_virtclass-native = ""
> +RDEPENDS_${PN} += "${EXTRA_RDEPENDS}"
Conversely, why is this stuff in the .bb file rather than in the .inc?
Presumably all the lines above are version invariant.
Also (although this isn't really a comment on your patch), why does
u-a-dpkg RDEPEND on dpkg in the first place? That seems like it rather
defeats the whole point of having this as a separate recipe.
p.
next prev parent reply other threads:[~2011-05-23 9:32 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-22 18:48 [PATCH 0/9] UPDATED: 21/22-May 2011 Pull Saul Wold
2011-05-22 18:48 ` [PATCH 1/9] gail: Add LIC_FILES_CHKSUM Saul Wold
2011-05-23 9:31 ` Phil Blundell
2011-05-22 18:48 ` [PATCH 2/9] update-alternatives-dpkg: Update to dpkg base 1.15.8.7 Saul Wold
2011-05-22 21:20 ` Joshua Lock
2011-05-23 9:29 ` Phil Blundell [this message]
2011-05-22 18:48 ` [PATCH 3/9] puzzles: update to r9173 Saul Wold
2011-05-22 18:48 ` [PATCH 4/9] package_rpm.bbclass: create method for createrepo cmd Saul Wold
2011-05-22 21:21 ` Joshua Lock
2011-05-23 14:39 ` Richard Purdie
2011-05-22 18:48 ` [PATCH 5/9] distcc_2.18.3.bb: Fix compilation on uclibc Saul Wold
2011-05-22 18:48 ` [PATCH 6/9] opkg_svn.bb: Install rcS.d into $D instead of $IMAGE_ROOTFS Saul Wold
2011-05-22 18:48 ` [PATCH 7/9] tcmode-default: switch to eglibc 2.13 from 2.12 Saul Wold
2011-05-22 18:48 ` [PATCH 8/9] tcmode-default: switch to gcc 4.6.0 for ppc & mips also Saul Wold
2011-05-22 18:48 ` [PATCH 9/9] gplv2 recipes update upstream status of patches Saul Wold
2011-05-23 14:36 ` [PATCH 0/9] UPDATED: 21/22-May 2011 Pull Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1306142943.2525.35.camel@phil-desktop \
--to=pb@pbcl.net \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.