From mboxrd@z Thu Jan 1 00:00:00 1970 From: Artem Bityutskiy Subject: Re: [PATCH -next] mtd: fix physmap.h warnings Date: Tue, 24 May 2011 08:53:51 +0300 Message-ID: <1306216431.2785.46.camel@localhost> References: <20110523154518.5e27cfb0.sfr@canb.auug.org.au> <20110523113709.4357b4ba.randy.dunlap@oracle.com> Reply-To: dedekind1@gmail.com Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail-ew0-f46.google.com ([209.85.215.46]:49851 "EHLO mail-ew0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751763Ab1EXF6L (ORCPT ); Tue, 24 May 2011 01:58:11 -0400 In-Reply-To: <20110523113709.4357b4ba.randy.dunlap@oracle.com> Sender: linux-next-owner@vger.kernel.org List-ID: To: Randy Dunlap , Russell King Cc: Stephen Rothwell , linux-mtd@lists.infradead.org, linux-next@vger.kernel.org, David Woodhouse , LKML , Marc Zyngier On Mon, 2011-05-23 at 11:37 -0700, Randy Dunlap wrote: > From: Randy Dunlap >=20 > Fix build warnings in physmap.h: >=20 > include/linux/mtd/physmap.h:25: warning: 'struct platform_device' dec= lared inside parameter list > include/linux/mtd/physmap.h:25: warning: its scope is only this defin= ition or declaration, which is probably not what you want > include/linux/mtd/physmap.h:26: warning: 'struct platform_device' dec= lared inside parameter list > include/linux/mtd/physmap.h:27: warning: 'struct platform_device' dec= lared inside parameter list >=20 > Signed-off-by: Randy Dunlap Oh, this was missed during review. This was introduced in b7281ca2a4b00044c60c25059f467d05772cdbe3 which is going in via Russel's tree, so I guess Russel could pick up your patch. CCed relevant people. --=20 Best Regards, Artem Bityutskiy (=D0=90=D1=80=D1=82=D1=91=D0=BC =D0=91=D0=B8=D1=82=D1=8E= =D1=86=D0=BA=D0=B8=D0=B9) From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ey0-f177.google.com ([209.85.215.177]) by canuck.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1QOkd9-0005Ay-QO for linux-mtd@lists.infradead.org; Tue, 24 May 2011 05:58:12 +0000 Received: by eyh6 with SMTP id 6so2348858eyh.36 for ; Mon, 23 May 2011 22:58:09 -0700 (PDT) Subject: Re: [PATCH -next] mtd: fix physmap.h warnings From: Artem Bityutskiy To: Randy Dunlap , Russell King In-Reply-To: <20110523113709.4357b4ba.randy.dunlap@oracle.com> References: <20110523154518.5e27cfb0.sfr@canb.auug.org.au> <20110523113709.4357b4ba.randy.dunlap@oracle.com> Content-Type: text/plain; charset="UTF-8" Date: Tue, 24 May 2011 08:53:51 +0300 Message-ID: <1306216431.2785.46.camel@localhost> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Cc: Stephen Rothwell , Marc Zyngier , LKML , linux-next@vger.kernel.org, linux-mtd@lists.infradead.org, David Woodhouse Reply-To: dedekind1@gmail.com List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Mon, 2011-05-23 at 11:37 -0700, Randy Dunlap wrote: > From: Randy Dunlap > > Fix build warnings in physmap.h: > > include/linux/mtd/physmap.h:25: warning: 'struct platform_device' declared inside parameter list > include/linux/mtd/physmap.h:25: warning: its scope is only this definition or declaration, which is probably not what you want > include/linux/mtd/physmap.h:26: warning: 'struct platform_device' declared inside parameter list > include/linux/mtd/physmap.h:27: warning: 'struct platform_device' declared inside parameter list > > Signed-off-by: Randy Dunlap Oh, this was missed during review. This was introduced in b7281ca2a4b00044c60c25059f467d05772cdbe3 which is going in via Russel's tree, so I guess Russel could pick up your patch. CCed relevant people. -- Best Regards, Artem Bityutskiy (Артём Битюцкий)