From: Rhyland Klein <rklein@nvidia.com>
To: Anton Vorontsov <cbouatmailru@gmail.com>
Cc: "bleung@google.com" <bleung@google.com>,
"olof@lixom.net" <olof@lixom.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] power: bq20z75: support external notification
Date: Tue, 24 May 2011 11:58:40 -0700 [thread overview]
Message-ID: <1306263520.31129.4.camel@rklein-linux2> (raw)
In-Reply-To: <20110524185802.GA10075@oksana.dev.rtsoft.ru>
On Tue, 2011-05-24 at 11:58 -0700, Anton Vorontsov wrote:
> On Thu, May 19, 2011 at 04:00:03PM -0700, Rhyland Klein wrote:
> [...]
> > + INIT_DELAYED_WORK(&bq20z75_device->work, bq20z75_delayed_work);
> > +
> > + bq20z75_device->enable_detection = true;
>
> Um... I don't follow this part.
>
> Especially considerting that the next patch just removes this line,
> but says that it "enables detection after registering". Hm.
>
> It says "need to enable detection" and removes "enable_detection = true".
>
> Could you explain what's going on here? :-)
>
> Thanks,
>
I messed up my patches, sorry about the confusion. The first patch
wasn't supposed to add it and the second was going to do it. Let me
refresh the patches and resend them. Sorry again.
-rhyland
prev parent reply other threads:[~2011-05-24 19:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-19 23:00 [PATCH 1/2] power: bq20z75: support external notification Rhyland Klein
2011-05-19 23:00 ` [PATCH 2/2] power: bq20z75: enable detection after registering Rhyland Klein
2011-05-24 18:58 ` [PATCH 1/2] power: bq20z75: support external notification Anton Vorontsov
2011-05-24 18:58 ` Rhyland Klein [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1306263520.31129.4.camel@rklein-linux2 \
--to=rklein@nvidia.com \
--cc=bleung@google.com \
--cc=cbouatmailru@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=olof@lixom.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.