From: Artem Bityutskiy <dedekind1@gmail.com>
To: Igor Grinberg <grinberg@compulab.co.il>
Cc: David Woodhouse <dwmw2@infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
linux-mtd@lists.infradead.org
Subject: Re: [PATCH 1/2] mtd: nand: generalized error messages with __func__
Date: Thu, 26 May 2011 08:16:48 +0300 [thread overview]
Message-ID: <1306387008.2785.138.camel@localhost> (raw)
In-Reply-To: <4DDDE19D.9010505@compulab.co.il>
On Thu, 2011-05-26 at 08:14 +0300, Igor Grinberg wrote:
> On 05/26/11 00:59, Brian Norris wrote:
>
> > These simple printk error messages can be a little simpler to maintain
> > when they use the __func__ identifier.
>
> While this is a good thing you are doing, I'd suggest using pr_err macro
> and may be even pr_fmt.
>
> pr_err() will save you from the need to define the log level each time.
> pr_fmt will save you the need to add %s: and __func__.
Right, but in this _particular_ case the best thing to do is to just
kill the error messages - if any of the allocation functions fail they
print a large scary warning with a backtrace anyway, and the backtrace
will contain the caller function names.
Brian, would you please instead just zap the prints?
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
next prev parent reply other threads:[~2011-05-26 5:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-25 21:59 [PATCH 1/2] mtd: nand: generalized error messages with __func__ Brian Norris
2011-05-25 21:59 ` [PATCH 2/2] mtd: nand: multi-line comment style fixups Brian Norris
2011-06-06 14:26 ` Artem Bityutskiy
2011-06-06 15:21 ` Brian Norris
2011-05-26 5:14 ` [PATCH 1/2] mtd: nand: generalized error messages with __func__ Igor Grinberg
2011-05-26 5:16 ` Artem Bityutskiy [this message]
2011-05-31 18:52 ` Brian Norris
2011-05-31 20:19 ` Mike Frysinger
2011-06-01 10:30 ` Artem Bityutskiy
2011-06-01 18:37 ` Brian Norris
2011-06-03 15:35 ` Artem Bityutskiy
2011-06-07 7:26 ` Igor Grinberg
2011-06-07 22:57 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1306387008.2785.138.camel@localhost \
--to=dedekind1@gmail.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=grinberg@compulab.co.il \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.