From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Darren Hart <dvhart@linux.intel.com>
Cc: poky@yoctoproject.org
Subject: Re: [PATCH 0/3] fetch2/git: debug updates and minor cleanup
Date: Fri, 27 May 2011 18:18:51 +0100 [thread overview]
Message-ID: <1306516731.27470.294.camel@rex> (raw)
In-Reply-To: <cover.1305932581.git.dvhart@linux.intel.com>
On Fri, 2011-05-20 at 16:06 -0700, Darren Hart wrote:
> From: Darren Hart <dvhart@linux.intel.com>
>
> Yu Ke,
>
> Please consider the following patches against the fetch2/git fetcher. The one
> point I would appreciate your review of is in 2/3. Is there a concern that
> the urldata has not been initialized at the point where I made the change?
>
> Pull URL: git://git.pokylinux.org/poky-contrib.git
> Branch: dvhart/git2
> Browse: http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=dvhart/git2
>
> Thanks,
> Darren Hart <dvhart@linux.intel.com>
> ---
>
>
> Darren Hart (3):
> fetch2/git: ensure network check log matches actual command
> fetch2/git: use logging.debug() and clarify messages
I merged these into bitbake master, thanks.
fetch2/git: use urldata basecmd when available
This one we a had a good reason for, at least a long time ago. It needs
some further checking into the callers (and better documentation if it
is deliberate). The fetcher world has changed a lot since those times...
I'm therefore holding off on it for now.
Cheers,
Richard
prev parent reply other threads:[~2011-05-27 17:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-20 23:06 [PATCH 0/3] fetch2/git: debug updates and minor cleanup Darren Hart
2011-05-20 23:06 ` [PATCH 1/3] fetch2/git: ensure network check log matches actual command Darren Hart
2011-05-20 23:06 ` [PATCH 2/3] fetch2/git: use urldata basecmd when available Darren Hart
2011-05-20 23:06 ` [PATCH 3/3] fetch2/git: use logging.debug() and clarify messages Darren Hart
2011-05-27 17:18 ` Richard Purdie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1306516731.27470.294.camel@rex \
--to=richard.purdie@linuxfoundation.org \
--cc=dvhart@linux.intel.com \
--cc=poky@yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.