From: Joe Perches <joe@perches.com>
To: julie Sullivan <kernelmail.jms@gmail.com>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
Randy Dunlap <randy.dunlap@oracle.com>,
devel@driverdev.osuosl.org, Dowan Kim <dowan@broadcom.com>,
Greg Kroah-Hartman <gregkh@suse.de>,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 2/4] staging: Remove direct includes of printk.h
Date: Sun, 29 May 2011 13:40:45 -0700 [thread overview]
Message-ID: <1306701645.14524.3.camel@Joe-Laptop> (raw)
In-Reply-To: <BANLkTimY9-ng8HVm+QFyS8FYks_mFx=ong@mail.gmail.com>
On Sun, 2011-05-29 at 18:00 +0100, julie Sullivan wrote:
> > --- a/drivers/staging/brcm80211/brcmfmac/dhd_sdio.c
[]
> types.h is also a subfile of kernel.h, right?
Yes it is.
> Or maybe you patched this one already - if so please excuse the noise :-)
No I didn't patch that one.
I think it wouldn't be good to do that.
printk.h may be a special case because it was
moved out of kernel.h just to make it a bit neater.
You are welcome to if you choose to.
There are like 1500 or so files that have both kernel.h and types.h
$ grep --include=*.[ch] -rP -l "^\s*\#\s*include\s+\<linux/types\.h>" * | \
xargs grep -Pl "^\s*\#\s*include\s+\<linux/kernel\.h\>" | wc -l
1572
next prev parent reply other threads:[~2011-05-29 20:40 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-25 9:09 [PATCH 1/4] include/linux/printk.h is not self-contained y
2011-05-25 14:42 ` Joe Perches
2011-05-25 15:20 ` Geert Uytterhoeven
2011-05-25 15:52 ` Alexey Dobriyan
2011-05-25 17:02 ` [PATCH 0/4] printk: cleanups of direct includes Joe Perches
2011-05-25 17:02 ` Joe Perches
2011-05-25 17:02 ` Joe Perches
2011-05-25 17:02 ` Joe Perches
2011-05-25 17:02 ` Joe Perches
2011-05-25 17:02 ` [PATCH 1/4] treewide: Remove direct includes of printk.h Joe Perches
2011-05-25 17:02 ` [PATCH 2/4] staging: " Joe Perches
2011-05-26 7:37 ` Roland Vossen
2011-05-29 17:00 ` julie Sullivan
2011-05-29 20:40 ` Joe Perches [this message]
2011-05-25 17:02 ` [PATCH 3/4] printk: Don't allow direct inclusion Joe Perches
2011-05-25 17:09 ` [PATCH 1/4] include/linux/printk.h is not self-contained Randy Dunlap
-- strict thread matches above, loose matches on Subject: below --
2011-05-25 17:02 [PATCH 4/4] treewide: Remove asmlinkage from printk Joe Perches
2011-05-25 17:02 ` Joe Perches
2011-05-25 17:02 ` Joe Perches
2011-05-25 17:02 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1306701645.14524.3.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=dowan@broadcom.com \
--cc=geert@linux-m68k.org \
--cc=gregkh@suse.de \
--cc=kernelmail.jms@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.