From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Hutchings Date: Tue, 31 May 2011 01:10:22 +0000 Subject: Re: [PATCH] bond_3ad.c: switch MAC_ADDRESS_COMPARE macro for Message-Id: <1306804222.4277.66.camel@localhost> List-Id: References: <20110531004418.GA22937@optiplex.tchesoft.com> In-Reply-To: <20110531004418.GA22937@optiplex.tchesoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: aquini@linux.com Cc: kernel-janitors@vger.kernel.org, Jay Vosburgh , David Miller , Andy Gospodarek , netdev@vger.kernel.org On Mon, 2011-05-30 at 21:44 -0300, Rafael Aquini wrote: > Converts all uses of MAC_ADDRESS_COMPARE macro to compare_ether_addr() and delete the macro. [...] Given all the casts you have to add, this doesn't seem like an improvement. How about replacing struct mac_addr with u8[ETH_ALEN] at the same time? You should also be able to get rid of null_mac_addr and use is_zero_ether_addr() instead. Ben. -- Ben Hutchings, Senior Software Engineer, Solarflare Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Hutchings Subject: Re: [PATCH] bond_3ad.c: switch MAC_ADDRESS_COMPARE macro for compare_ether_addr() Date: Tue, 31 May 2011 02:10:22 +0100 Message-ID: <1306804222.4277.66.camel@localhost> References: <20110531004418.GA22937@optiplex.tchesoft.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: kernel-janitors@vger.kernel.org, Jay Vosburgh , David Miller , Andy Gospodarek , netdev@vger.kernel.org To: aquini@linux.com Return-path: Received: from mail.solarflare.com ([216.237.3.220]:36752 "EHLO exchange.solarflare.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751002Ab1EaBMR (ORCPT ); Mon, 30 May 2011 21:12:17 -0400 In-Reply-To: <20110531004418.GA22937@optiplex.tchesoft.com> Sender: netdev-owner@vger.kernel.org List-ID: On Mon, 2011-05-30 at 21:44 -0300, Rafael Aquini wrote: > Converts all uses of MAC_ADDRESS_COMPARE macro to compare_ether_addr() and delete the macro. [...] Given all the casts you have to add, this doesn't seem like an improvement. How about replacing struct mac_addr with u8[ETH_ALEN] at the same time? You should also be able to get rid of null_mac_addr and use is_zero_ether_addr() instead. Ben. -- Ben Hutchings, Senior Software Engineer, Solarflare Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked.