All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Brian Norris" <computersforpeace@gmail.com>
To: linux-mtd@lists.infradead.org
Cc: baruch@tkos.co.il, Kevin Cernekee <cernekee@gmail.com>,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	nsekhar@ti.com, b25806@freescale.com, tie-fei.zang@freescale.com,
	linux-mtd@lists.infradead.org,
	Florian Fainelli <ffainelli@freebox.fr>,
	jamie@jamieiles.com, Ivan Djelic <ivan.djelic@parrot.com>,
	kernel@wantstofly.org, khilman@ti.com, jesper.nilsson@axis.com,
	kgene.kim@samsung.com, linux@arm.linux.org.uk, hjk@linutronix.de,
	r64343@freescale.com, u.kleine-koenig@pengutronix.de,
	Ricard Wanderlof <ricard.wanderlof@axis.com>,
	alex@digriz.org.uk, john.ogness@linutronix.de,
	lucas.demarchi@profusion.mobi, nicolas.ferre@atmel.com,
	s.hauer@pengutronix.de, starvik@axis.com, joe@perches.com,
	ben-linux@fluff.org, cbouatmailru@gmail.com,
	linux-arm-kernel@lists.infradead.org, grant.likely@secretlab.ca,
	hong.xu@atmel.com, linux-cris-kernel@axis.com,
	sbranden@broadcom.com, nico@fluxnic.net, jkosina@suse.cz,
	Artem Bityutskiy <dedekind1@gmail.com>,
	blp@cs.stanford.edu, w.sang@pengutronix.de,
	mware@elphinstone.net, jdzheng@broadcom.com,
	chuanxiao.dong@intel.com, olof@lixom.net,
	Brian Norris <computersforpeace@gmail.com>,
	David Woodhouse <dwmw2@infradead.org>
Subject: [PATCH 5/8] mtd: nand: move NAND_CREATE_EMPTY_BBT flag
Date: Tue, 31 May 2011 16:31:24 -0700	[thread overview]
Message-ID: <1306884687-1824-6-git-send-email-computersforpeace@gmail.com> (raw)
In-Reply-To: <1306884687-1824-1-git-send-email-computersforpeace@gmail.com>

The NAND_CREATE_EMPTY_BBT flag was added by commit:
  453281a973c10bce941b240d1c654d536623b16b
  mtd: nand: introduce NAND_CREATE_EMPTY_BBT
This flag is not used within the kernel and not explained well, so I
took the liberty to edit its comments.

Also, this is a BBT-related flag (and closely tied with NAND_BBT_CREATE)
so I'm moving it to bbm.h next to NAND_BBT_CREATE, thus requiring that
we use the flag in nand_chip.bbt_options, *not* in nand_chip.options.

Signed-off-by: Brian Norris <computersforpeace@gmail.com>
---
 drivers/mtd/nand/nand_bbt.c |    2 +-
 include/linux/mtd/bbm.h     |    7 +++++++
 include/linux/mtd/nand.h    |    2 --
 3 files changed, 8 insertions(+), 3 deletions(-)

diff --git a/drivers/mtd/nand/nand_bbt.c b/drivers/mtd/nand/nand_bbt.c
index dfea9fd..2e4e259 100644
--- a/drivers/mtd/nand/nand_bbt.c
+++ b/drivers/mtd/nand/nand_bbt.c
@@ -970,7 +970,7 @@ static int check_create(struct mtd_info *mtd, uint8_t *buf, struct nand_bbt_desc
 			continue;
 
 		/* Create the table in memory by scanning the chip(s) */
-		if (!(this->options & NAND_CREATE_EMPTY_BBT))
+		if (!(this->bbt_options & NAND_CREATE_EMPTY_BBT))
 			create_bbt(mtd, buf, bd, chipsel);
 
 		td->version[i] = 1;
diff --git a/include/linux/mtd/bbm.h b/include/linux/mtd/bbm.h
index ff18c08..3cf4a8a 100644
--- a/include/linux/mtd/bbm.h
+++ b/include/linux/mtd/bbm.h
@@ -86,6 +86,13 @@ struct nand_bbt_descr {
 #define NAND_BBT_VERSION	0x00000100
 /* Create a bbt if none exists */
 #define NAND_BBT_CREATE		0x00000200
+/*
+ * Create an empty BBT with no vendor information. Vendor's information may be
+ * unavailable, for example, if the NAND controller has a different data and OOB
+ * layout or if this information is already purged. Must be used in conjunction
+ * with NAND_BBT_CREATE.
+ */
+#define NAND_CREATE_EMPTY_BBT	0x01000000
 /* Search good / bad pattern through all pages of a block */
 #define NAND_BBT_SCANALLPAGES	0x00000400
 /* Scan block empty during good / bad block scan */
diff --git a/include/linux/mtd/nand.h b/include/linux/mtd/nand.h
index f68e8cb..4e9e88b 100644
--- a/include/linux/mtd/nand.h
+++ b/include/linux/mtd/nand.h
@@ -228,8 +228,6 @@ typedef enum {
 #define NAND_OWN_BUFFERS	0x00040000
 /* Chip may not exist, so silence any errors in scan */
 #define NAND_SCAN_SILENT_NODEV	0x00080000
-/* Create an empty BBT with no vendor information if the BBT is available */
-#define NAND_CREATE_EMPTY_BBT		0x01000000
 
 /* Options set by nand scan */
 /* Nand scan has allocated controller struct */
-- 
1.7.0.4

WARNING: multiple messages have this Message-ID (diff)
From: computersforpeace@gmail.com (Brian Norris)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/8] mtd: nand: move NAND_CREATE_EMPTY_BBT flag
Date: Tue, 31 May 2011 16:31:24 -0700	[thread overview]
Message-ID: <1306884687-1824-6-git-send-email-computersforpeace@gmail.com> (raw)
In-Reply-To: <1306884687-1824-1-git-send-email-computersforpeace@gmail.com>

The NAND_CREATE_EMPTY_BBT flag was added by commit:
  453281a973c10bce941b240d1c654d536623b16b
  mtd: nand: introduce NAND_CREATE_EMPTY_BBT
This flag is not used within the kernel and not explained well, so I
took the liberty to edit its comments.

Also, this is a BBT-related flag (and closely tied with NAND_BBT_CREATE)
so I'm moving it to bbm.h next to NAND_BBT_CREATE, thus requiring that
we use the flag in nand_chip.bbt_options, *not* in nand_chip.options.

Signed-off-by: Brian Norris <computersforpeace@gmail.com>
---
 drivers/mtd/nand/nand_bbt.c |    2 +-
 include/linux/mtd/bbm.h     |    7 +++++++
 include/linux/mtd/nand.h    |    2 --
 3 files changed, 8 insertions(+), 3 deletions(-)

diff --git a/drivers/mtd/nand/nand_bbt.c b/drivers/mtd/nand/nand_bbt.c
index dfea9fd..2e4e259 100644
--- a/drivers/mtd/nand/nand_bbt.c
+++ b/drivers/mtd/nand/nand_bbt.c
@@ -970,7 +970,7 @@ static int check_create(struct mtd_info *mtd, uint8_t *buf, struct nand_bbt_desc
 			continue;
 
 		/* Create the table in memory by scanning the chip(s) */
-		if (!(this->options & NAND_CREATE_EMPTY_BBT))
+		if (!(this->bbt_options & NAND_CREATE_EMPTY_BBT))
 			create_bbt(mtd, buf, bd, chipsel);
 
 		td->version[i] = 1;
diff --git a/include/linux/mtd/bbm.h b/include/linux/mtd/bbm.h
index ff18c08..3cf4a8a 100644
--- a/include/linux/mtd/bbm.h
+++ b/include/linux/mtd/bbm.h
@@ -86,6 +86,13 @@ struct nand_bbt_descr {
 #define NAND_BBT_VERSION	0x00000100
 /* Create a bbt if none exists */
 #define NAND_BBT_CREATE		0x00000200
+/*
+ * Create an empty BBT with no vendor information. Vendor's information may be
+ * unavailable, for example, if the NAND controller has a different data and OOB
+ * layout or if this information is already purged. Must be used in conjunction
+ * with NAND_BBT_CREATE.
+ */
+#define NAND_CREATE_EMPTY_BBT	0x01000000
 /* Search good / bad pattern through all pages of a block */
 #define NAND_BBT_SCANALLPAGES	0x00000400
 /* Scan block empty during good / bad block scan */
diff --git a/include/linux/mtd/nand.h b/include/linux/mtd/nand.h
index f68e8cb..4e9e88b 100644
--- a/include/linux/mtd/nand.h
+++ b/include/linux/mtd/nand.h
@@ -228,8 +228,6 @@ typedef enum {
 #define NAND_OWN_BUFFERS	0x00040000
 /* Chip may not exist, so silence any errors in scan */
 #define NAND_SCAN_SILENT_NODEV	0x00080000
-/* Create an empty BBT with no vendor information if the BBT is available */
-#define NAND_CREATE_EMPTY_BBT		0x01000000
 
 /* Options set by nand scan */
 /* Nand scan has allocated controller struct */
-- 
1.7.0.4

  parent reply	other threads:[~2011-05-31 23:31 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-31 23:31 [PATCH 0/8] clean-up NAND / BBT code, flags Brian Norris
2011-05-31 23:31 ` Brian Norris
2011-05-31 23:31 ` [PATCH 1/8] mtd: nand: remove NAND_BBT_SCANBYTE1AND6 option Brian Norris
2011-07-08 16:35   ` Brian Norris
2011-05-31 23:31 ` [PATCH 2/8] mtd: nand: separate chip options / bbt_options Brian Norris
2011-05-31 23:31   ` Brian Norris
2011-05-31 23:31 ` [PATCH 3/8] mtd: nand: consolidate redundant flash-based BBT flags Brian Norris
2011-05-31 23:31   ` Brian Norris
2011-05-31 23:31 ` [PATCH 4/8] mtd: nand: rename NAND_USE_FLASH_BBT Brian Norris
2011-05-31 23:31   ` Brian Norris
2011-05-31 23:31 ` Brian Norris [this message]
2011-05-31 23:31   ` [PATCH 5/8] mtd: nand: move NAND_CREATE_EMPTY_BBT flag Brian Norris
2011-05-31 23:31 ` [PATCH 6/8] mtd: nand: rename CREATE_EMPTY bbt flag with proper prefix Brian Norris
2011-05-31 23:31   ` Brian Norris
2011-05-31 23:31 ` [PATCH 7/8] mtd: nand: renumber the reorganized flags in nand.h / bbm.h Brian Norris
2011-05-31 23:31   ` Brian Norris
2011-05-31 23:31 ` [PATCH 8/8] mtd: nand: improve comment on NAND_BBT_DYNAMIC_STRUCT Brian Norris
2011-05-31 23:31   ` Brian Norris
2011-06-01 11:43 ` [PATCH 0/8] clean-up NAND / BBT code, flags Artem Bityutskiy
2011-06-01 11:43   ` Artem Bityutskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1306884687-1824-6-git-send-email-computersforpeace@gmail.com \
    --to=computersforpeace@gmail.com \
    --cc=alex@digriz.org.uk \
    --cc=b25806@freescale.com \
    --cc=baruch@tkos.co.il \
    --cc=ben-linux@fluff.org \
    --cc=bigeasy@linutronix.de \
    --cc=blp@cs.stanford.edu \
    --cc=cbouatmailru@gmail.com \
    --cc=cernekee@gmail.com \
    --cc=chuanxiao.dong@intel.com \
    --cc=dedekind1@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=ffainelli@freebox.fr \
    --cc=grant.likely@secretlab.ca \
    --cc=hjk@linutronix.de \
    --cc=hong.xu@atmel.com \
    --cc=ivan.djelic@parrot.com \
    --cc=jamie@jamieiles.com \
    --cc=jdzheng@broadcom.com \
    --cc=jesper.nilsson@axis.com \
    --cc=jkosina@suse.cz \
    --cc=joe@perches.com \
    --cc=john.ogness@linutronix.de \
    --cc=kernel@wantstofly.org \
    --cc=kgene.kim@samsung.com \
    --cc=khilman@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-cris-kernel@axis.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux@arm.linux.org.uk \
    --cc=lucas.demarchi@profusion.mobi \
    --cc=mware@elphinstone.net \
    --cc=nico@fluxnic.net \
    --cc=nicolas.ferre@atmel.com \
    --cc=nsekhar@ti.com \
    --cc=olof@lixom.net \
    --cc=r64343@freescale.com \
    --cc=ricard.wanderlof@axis.com \
    --cc=s.hauer@pengutronix.de \
    --cc=sbranden@broadcom.com \
    --cc=starvik@axis.com \
    --cc=tie-fei.zang@freescale.com \
    --cc=u.kleine-koenig@pengutronix.de \
    --cc=w.sang@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.