diff for duplicates of <1307122985.2016.72.camel@deskari> diff --git a/a/1.txt b/N1/1.txt index a814f8e..ffbbbd2 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -25,11 +25,11 @@ On Fri, 2011-06-03 at 09:45 -0700, Kevin Hilman wrote: Yes, the counter. I don't think -if (dispc.runtime_count++ = 0) +if (dispc.runtime_count++ == 0) is thread safe. -> > + if (dispc.runtime_count++ = 0) { +> > + if (dispc.runtime_count++ == 0) { > > You shouldn't need your own use-counting here. The runtime PM core is > already doing usage counting. @@ -43,7 +43,7 @@ Yes, I wish I could do that =). I tried to explain this in the 00-patch, I guess I should've explained it in this patch also. Perhaps also in a comment. -From the introduction: +>From the introduction: --- @@ -122,7 +122,7 @@ except one which I've answered also. > > +{ > > + mutex_lock(&dispc.runtime_lock); > > + -> > + if (--dispc.runtime_count = 0) { +> > + if (--dispc.runtime_count == 0) { > > + int r; > > Same problem here. diff --git a/a/content_digest b/N1/content_digest index c76d0b1..1a03c46 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -3,7 +3,7 @@ "ref\0871uzahnib.fsf@ti.com\0" "From\0Tomi Valkeinen <tomi.valkeinen@ti.com>\0" "Subject\0Re: [PATCH 19/27] OMAP: DSS2: Use PM runtime & HWMOD support\0" - "Date\0Fri, 03 Jun 2011 17:43:05 +0000\0" + "Date\0Fri, 03 Jun 2011 20:43:05 +0300\0" "To\0Kevin Hilman <khilman@ti.com>\0" "Cc\0linux-omap@vger.kernel.org" linux-fbdev@vger.kernel.org @@ -38,11 +38,11 @@ "\n" "Yes, the counter. I don't think\n" "\n" - "if (dispc.runtime_count++ = 0)\n" + "if (dispc.runtime_count++ == 0)\n" "\n" "is thread safe.\n" "\n" - "> > +\tif (dispc.runtime_count++ = 0) {\n" + "> > +\tif (dispc.runtime_count++ == 0) {\n" "> \n" "> You shouldn't need your own use-counting here. The runtime PM core is\n" "> already doing usage counting.\n" @@ -56,7 +56,7 @@ "I tried to explain this in the 00-patch, I guess I should've explained\n" "it in this patch also. Perhaps also in a comment.\n" "\n" - "From the introduction:\n" + ">From the introduction:\n" "\n" "---\n" "\n" @@ -135,7 +135,7 @@ "> > +{\n" "> > +\tmutex_lock(&dispc.runtime_lock);\n" "> > +\n" - "> > +\tif (--dispc.runtime_count = 0) {\n" + "> > +\tif (--dispc.runtime_count == 0) {\n" "> > +\t\tint r;\n" "> \n" "> Same problem here. \n" @@ -159,4 +159,4 @@ "\n" Tomi -54e1a6e375aa3c314c975bb0daa5a49f919beae917f8a1cff978b164009d64c5 +fc7f7c61158b9fd0cefcea2b17e538d18cb6e1e8eb6719c7475ed0f2f7c6d12f
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.