All of lore.kernel.org
 help / color / mirror / Atom feed
From: Artem Bityutskiy <dedekind1@gmail.com>
To: Mike Frysinger <vapier@gentoo.org>
Cc: linux-mtd@lists.infradead.org
Subject: Re: [PATCH 4/5] flash_{lock,unlock}: convert to common code
Date: Mon, 06 Jun 2011 15:26:38 +0300	[thread overview]
Message-ID: <1307363198.3112.51.camel@localhost> (raw)
In-Reply-To: <1307333354-26583-4-git-send-email-vapier@gentoo.org>

On Mon, 2011-06-06 at 00:09 -0400, Mike Frysinger wrote:
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> ---
>  flash_unlock.c |   75 ++++++++++++++++++++++++++++++-------------------------
>  1 files changed, 41 insertions(+), 34 deletions(-)

Pushed, but tweaked a bit ...

> +	/*
> +	 * Get the device info to compare to command line sizes
> +	 */

Made the comment style to be the same as we use in the kernel - one line
for short comments. Changed the existing comment as well. It could be a
separate patch, but let's use a simplified way in this case :-)

-- 
Best Regards,
Artem Bityutskiy (Артём Битюцкий)

  reply	other threads:[~2011-06-06 12:30 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-06  4:09 [PATCH 1/5] flash_lock/flash_unlock/flash_info: clean up style Mike Frysinger
2011-06-06  4:09 ` [PATCH 2/5] flash_{lock,unlock}: merge functionality Mike Frysinger
2011-06-06 12:20   ` Artem Bityutskiy
2011-06-06  4:09 ` [PATCH 3/5] flash_{lock,unlock}: merge into one util Mike Frysinger
2011-06-06 12:24   ` Artem Bityutskiy
2011-06-06  4:09 ` [PATCH 4/5] flash_{lock,unlock}: convert to common code Mike Frysinger
2011-06-06 12:26   ` Artem Bityutskiy [this message]
2011-06-06  4:09 ` [PATCH 5/5] flash_{lock, unlock}: fix off-by-one error for "entire device" length Mike Frysinger
2011-06-06 12:28   ` Artem Bityutskiy
2011-06-06 12:19 ` [PATCH 1/5] flash_lock/flash_unlock/flash_info: clean up style Artem Bityutskiy
2011-06-06 12:19   ` Artem Bityutskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1307363198.3112.51.camel@localhost \
    --to=dedekind1@gmail.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=vapier@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.