From mboxrd@z Thu Jan  1 00:00:00 1970
From: Pekka Enberg <penberg@kernel.org>
Subject: Re: [PATCH v2] kvm tools, vesa: Use guest-mapped memory for
 framebuffer
Date: Mon, 06 Jun 2011 17:05:00 +0300
Message-ID: <1307369100.27309.9.camel@jaguar>
References: <1307368589-11682-1-git-send-email-penberg@kernel.org>
	 <5D948741-FBA0-40AE-8C74-9653BB33025D@suse.de>
Mime-Version: 1.0
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: 7bit
Cc: kvm@vger.kernel.org, Cyrill Gorcunov <gorcunov@gmail.com>,
	Ingo Molnar <mingo@elte.hu>, John Floren <john@jfloren.net>,
	Sasha Levin <levinsasha928@gmail.com>
To: Alexander Graf <agraf@suse.de>
Return-path: <kvm-owner@vger.kernel.org>
Received: from filtteri6.pp.htv.fi ([213.243.153.189]:53799 "EHLO
	filtteri6.pp.htv.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752785Ab1FFOFD (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 6 Jun 2011 10:05:03 -0400
In-Reply-To: <5D948741-FBA0-40AE-8C74-9653BB33025D@suse.de>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Mon, 2011-06-06 at 15:59 +0200, Alexander Graf wrote:
> Please keep in mind that this is pretty fragile. It will probably work out for you now, but memslots are
> 
>   1) limited

I assume KVM_SET_USER_MEMORY_REGION doesn't fail silenty here?

>   2) don't deal with overlap
> 
> So please add at least a comment here, warning people that this is a
> very simple implementation that could break in subtile ways when
> implementing other hardware that could map its own memory regions
> somewhere else (PCI BARs), but wants them backed by RAM.

Sure - I'll add a comment saying the function doesn't handle overlapping
memory regions.