All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Hansen <dave@linux.vnet.ibm.com>
To: "Paradis, James" <James.Paradis@stratus.com>
Cc: linux-mm@kvack.org
Subject: Re: [PATCH] REPOST: Dirty page tracking for physical system migration
Date: Tue, 07 Jun 2011 14:29:44 -0700	[thread overview]
Message-ID: <1307482184.3048.111.camel@nimitz> (raw)
In-Reply-To: <AC1B83CE65082B4DBDDB681ED2F6B2EF1ACDA0@EXHQ.corp.stratus.com>

On Tue, 2011-06-07 at 16:54 -0400, Paradis, James wrote:
>  /* Set of bits not changed in pte_modify */
>  #define _PAGE_CHG_MASK (PTE_PFN_MASK | _PAGE_PCD | _PAGE_PWT |
> \
> -                        _PAGE_SPECIAL | _PAGE_ACCESSED | _PAGE_DIRTY)
> +                        _PAGE_SPECIAL | _PAGE_ACCESSED | _PAGE_DIRTY
> |
> \
> +                        _PAGE_SOFTDIRTY)
>  #define _HPAGE_CHG_MASK (_PAGE_CHG_MASK | _PAGE_PSE)
>  
>  #define _PAGE_CACHE_MASK       (_PAGE_PCD | _PAGE_PWT)

This is still line-wrapped, corrupt, and unapplyable. :(

You might want to check out Documentation/email-clients.txt

> --- a/arch/x86/mm/Makefile
> +++ b/arch/x86/mm/Makefile
> @@ -30,3 +30,5 @@ obj-$(CONFIG_NUMA_EMU)                +=
> numa_emulation.o
>  obj-$(CONFIG_HAVE_MEMBLOCK)            += memblock.o
>  
>  obj-$(CONFIG_MEMTEST)          += memtest.o
> +
> +obj-$(CONFIG_TRACK_DIRTY_PAGES)        += track.o 

I think you missed track.c in this patch.  Maybe you forgot to add -N to
your diff.

-- Dave

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2011-06-07 21:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-07 20:54 [PATCH] REPOST: Dirty page tracking for physical system migration Paradis, James
2011-06-07 21:29 ` Dave Hansen [this message]
2011-06-07 21:32   ` Paradis, James

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1307482184.3048.111.camel@nimitz \
    --to=dave@linux.vnet.ibm.com \
    --cc=James.Paradis@stratus.com \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.