From: Joe Perches <joe@perches.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Liam Girdwood <lrg@ti.com>,
linux-kernel@vger.kernel.org,
patches@opensource.wolfsonmicro.com
Subject: Re: [PATCH] regulator: Add rdev_crit() macro
Date: Thu, 09 Jun 2011 11:37:15 -0700 [thread overview]
Message-ID: <1307644635.13329.36.camel@Joe-Laptop> (raw)
In-Reply-To: <1307631997-32061-1-git-send-email-broonie@opensource.wolfsonmicro.com>
On Thu, 2011-06-09 at 16:06 +0100, Mark Brown wrote:
> No actual users but provide the macro so there's less surprise when it's
> not there.
>
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---
> drivers/regulator/core.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
> index 47bf85d..f5e4665 100644
> --- a/drivers/regulator/core.c
> +++ b/drivers/regulator/core.c
> @@ -34,6 +34,8 @@
>
> #include "dummy.h"
>
> +#define rdev_crit(rdev, fmt, ...) \
> + pr_crit("%s: " fmt, rdev_get_name(rdev), ##__VA_ARGS__)
> #define rdev_err(rdev, fmt, ...) \
> pr_err("%s: " fmt, rdev_get_name(rdev), ##__VA_ARGS__)
> #define rdev_warn(rdev, fmt, ...) \
If that's really necessary, shouldn't rdev_emerg, rdev_alert
and rdev_notice be added as well?
next prev parent reply other threads:[~2011-06-09 18:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-09 15:06 [PATCH] regulator: Add rdev_crit() macro Mark Brown
2011-06-09 18:15 ` Liam Girdwood
2011-06-09 18:37 ` Joe Perches [this message]
2011-06-09 19:09 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1307644635.13329.36.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=patches@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.